On 01/15/15 14:04, Wireshark code review wrote:
URL:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e75dd98b3d9a8b4177461c8dd2c6e547b5fe5924
Submitter: Martin Mathieson ([email protected])
Changed: branch: master
Repository: wireshark
Commits:
e75dd98 by Alexis La Goutte ([email protected]):
NetFlow: Assign instead of compare (CID 1262419 & 1262420)
That's one of the problems with "too many" parenthesis. GCC would have
caught this were it not for the parenthesis around the condition:
../../../epan/dissectors/packet-netflow.c: In function
'dissect_v9_v10_pdu_data':
../../../epan/dissectors/packet-netflow.c:3009:17: error: suggest parentheses
around assignment used as truth value [-Werror=parentheses]
else if (pen_type = 182 || (ip_protocol == IP_PROTO_TCP)) {
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <[email protected]>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:[email protected]?subject=unsubscribe
