On Wed, 2016-02-10 at 10:46 -0500, Michael McConville wrote: > Signed overflow is undefined, so the overflow check below is > technically > meaningless. Because we're only checking whether an increment will > overflow, we can compare j to G_MAXINT instead. > This is an important fix. The compiler is allowed to (and often will) just omit that checking code and replace with with a false because it can never evaluate to true using only defined behaviour. That check is effectively useless as currently written.
signature.asc
Description: This is a digitally signed message part
Description: S/MIME cryptographic signature___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
