On 10/03/2016 11:10, Guy Harris wrote:
On Mar 9, 2016, at 2:04 PM, Mike Morrin <[email protected]> wrote:
I am trying to get the packet-dof dissector merged into the Wireshark source
tree, but have just discovered that the dissector requires libcrypt v1.6.0 or
newer, which is OK for a Windows build (as the Windows libraries are new
enough).
But the Ubuntu petri dish machine (and I presume the other build-bots) have an
older, incompatible version of the library.
I can detect the library version at install time, and compile the dissector
without security if the build machine does not have the correct library version.
Do you mean "install time" or "build time"?
I meant "build time", as the dissector won't build with the older header
file, and subsequently "run time" becomes irrelevant.
But will that pass review?
We do all *sorts* of checks for the presence, and capabilities, of various
libraries in the autotools and CMake build processes, so checking at build time
and only compiling the security stuff into the dissector if we have a version
of libcrypt that can support it would not be doing something we haven't already
done in the past, so that wouldn't be a version to reject that change.
I was intending to do the version check inside the dissector source
file, that seems easier than putting an exceptional case into the make
system.
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <[email protected]>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:[email protected]?subject=unsubscribe
