Hi Paul, 2016-11-26 16:35 GMT+01:00 Paul Offord <[email protected]>:
> Hi Alexis et al., > > What are Modelines? Are they the lines that state how the editor is > configured? Is it OK if I just copy them from an existing source file? > Those are the footer you find in each (or almost each) file indicating the coding rules for the file. You can find an editor here: https://www.wireshark.org/tools/modelines.html It's not simply about copy/pasting it from another dissector, but also ensure it matches your indentation style. > > Thanks and regards...Paul > > -----Original Message----- > From: Alexis La Goutte (Code Review) [mailto:code-review-do-not- > [email protected]] > Sent: 26 November 2016 15:27 > To: Paul Offord <[email protected]> > Cc: Evan Huus <[email protected]>; Petri Dish Buildbot < > [email protected]>; Anders Broman <[email protected]>; > Jaap Keuter <[email protected]>; Michael Mann <[email protected]> > Subject: Change in wireshark[master]: transum: plugin code > > Alexis La Goutte has posted comments on this change. > > Change subject: transum: plugin code > ...................................................................... > > > Patch Set 7: Petri-Dish+1 > > (9 comments) > > https://code.wireshark.org/review/#/c/17750/7/plugins/transum/decoders.c > File plugins/transum/decoders.c: > > Line 304 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/transum/decoders.h > File plugins/transum/decoders.h: > > Line 32 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/transum/extractors.c > File plugins/transum/extractors.c: > > Line 121 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/transum/extractors.h > File plugins/transum/extractors.h: > > Line 34 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/transum/moduleinfo.h > File plugins/transum/moduleinfo.h: > > Line 40 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/ > transum/packet-transum.c > File plugins/transum/packet-transum.c: > > Line 1409 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/ > transum/packet-transum.h > File plugins/transum/packet-transum.h: > > Line 26: #define ETH_TYPE_IPV6 0x86dd > May be import value from epan/ipproto ? > > > Line 186 > Add Modelines > > > https://code.wireshark.org/review/#/c/17750/7/plugins/ > transum/preferences.h > File plugins/transum/preferences.h: > > Line 56 > Add Modelines > > > -- > To view, visit https://code.wireshark.org/review/17750 > To unsubscribe, visit https://code.wireshark.org/review/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I47d7e5354fc269916851a318fef10b826897eaf8 > Gerrit-PatchSet: 7 > Gerrit-Project: wireshark > Gerrit-Branch: master > Gerrit-Owner: Paul Offord <[email protected]> > Gerrit-Reviewer: Alexis La Goutte <[email protected]> > Gerrit-Reviewer: Anders Broman <[email protected]> > Gerrit-Reviewer: Evan Huus <[email protected]> > Gerrit-Reviewer: Jaap Keuter <[email protected]> > Gerrit-Reviewer: Michael Mann <[email protected]> > Gerrit-Reviewer: Paul Offord <[email protected]> > Gerrit-Reviewer: Petri Dish Buildbot <[email protected]> > Gerrit-HasComments: Yes > > ______________________________________________________________________ > > This message contains confidential information and is intended only for > the individual named. If you are not the named addressee you should not > disseminate, distribute or copy this e-mail. Please notify the sender > immediately by e-mail if you have received this e-mail by mistake and > delete this e-mail from your system. > > Any views or opinions expressed are solely those of the author and do not > necessarily represent those of Advance Seven Ltd. E-mail transmission > cannot be guaranteed to be secure or error-free as information could be > intercepted, corrupted, lost, destroyed, arrive late or incomplete, or > contain viruses. The sender therefore does not accept liability for any > errors or omissions in the contents of this message, which arise as a > result of e-mail transmission. > > Advance Seven Ltd. Registered in England & Wales numbered 2373877 at > Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ > > ______________________________________________________________________ > This email has been scanned by the Symantec Email Security.cloud service. > For more information please visit http://www.symanteccloud.com > ______________________________________________________________________ > ____________________________________________________________ > _______________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject= > unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
