Hi Graham,

I don’t seem to have that folder in my solution.  Here’s a screenshot:

[cid:[email protected]]

I’ve changed main_toolbar.c by just navigating to the filesystem directory and 
then opening it.  I’m in git/git-review/Windows hell at the moment – I’ll take 
that up on a separate mail thread.  Once I get that working I’ll push the fix.

Best regards…Paul

From: [email protected] 
[mailto:[email protected]] On Behalf Of Graham Bloice
Sent: 17 January 2017 17:31
To: Developer support list for Wireshark <[email protected]>
Subject: Re: [Wireshark-dev] main_toolbar.c in code tree but not in solution



On 17 January 2017 at 17:04, Paul Offord 
<[email protected]<mailto:[email protected]>> wrote:
Hi,

I’m working on a fix for Bug 12973.  It’s a very simple fix to main_window.cpp 
for the Qt UI and main_toolbar.c for the GTK one.  I’m working with source from 
a git clone taken this morning.  Although main_window.cpp is showing in the VS 
2013 solution, main_toobar.c doesn’t.  Both files are in the code tree.


  *   Is main_toolbar.c no longer needed?
  *   Do I need to code a fix for the GTK UI?

Thanks and regards…Paul


main_toolbar.c is still used (see UI\gtkui\Source Files in the solution 
explorer) and yes, preferably fix both.

--
Graham Bloice

______________________________________________________________________

This message contains confidential information and is intended only for the 
individual named. If you are not the named addressee you should not 
disseminate, distribute or copy this e-mail. Please notify the sender 
immediately by e-mail if you have received this e-mail by mistake and delete 
this e-mail from your system.

Any views or opinions expressed are solely those of the author and do not 
necessarily represent those of Advance Seven Ltd. E-mail transmission cannot be 
guaranteed to be secure or error-free as information could be intercepted, 
corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The 
sender therefore does not accept liability for any errors or omissions in the 
contents of this message, which arise as a result of e-mail transmission.

Advance Seven Ltd. Registered in England & Wales numbered 2373877 at Endeavour 
House, Coopers End Lane, Stansted, Essex CM24 1SJ

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com
______________________________________________________________________
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe

Reply via email to