Hi Nitzan, 2017-01-25 0:26 GMT+01:00 Nitzan Carmi <[email protected]>:
> Hi, > > > > At the past month I've been working on a new dissector for Wireshark, to > parse NVME protocol (with a focus on the fabrics channel – Infiniband/RDMA). > > So far, although not all commands are fully parsed yet (lots of commands > to cover), the dissection flow is working correctly, thus I think I reached > a milestone and > > this is a good time to share the code and take comments before I continue. > > But, since I am new to Wireshark, I would like to know (and save > everybody's time) if there are things I need to check or pay attention to > > (beyond the fuzz testing I already read about) Before I push my dissector > to gerrit for review. > Ensure to copy the tools/pre-commit and tools/commit-msg files in the .git/hooks folder of your Wireshark source code. It will run various checks locally during the 'git commit' command execution and will automatically add the Change-Id line required by Gerrit to your commit message. Best regards, Pascal.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
