I still say the answer is "it depends" with respect to large vs. small as it's more about complexity. If you're adding request/response tracking, conversation data, or changes to a state machine those can get complicated quickly so a small patch would be preferred. If you need to add 100 fields to dissector, but the dissection itself is fairly straightforward (just TLVs, or simple structure/lists of fields), that's okay as one large patch. -----Original Message----- From: Bertin Nicolas <[email protected]> To: Developer support list for Wireshark <[email protected]> Sent: Wed, Apr 19, 2017 7:11 am Subject: [Wireshark-dev] small vs large patch sets ?
Hi, I'm updating 2 dissectors (packet-noe and packet-ua3g). So far, I've submitted changes one by one (small patches). I believe it's the preferred solution for reviewers instead of a large patch with everything in it. Can you confirm? Until now, I've wait for a patch to be merged before submitting the next one. My workflow is probably wrong... Is there a better way of doing thing? ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
