We do not have any other dissector within the code, which dissects blocktypes. Therefore I would not be so sure, that it will get rejected (in my book it definitely should not).
But it most likely will get rejected as a plugin. Main reasons for built-in: - Easier to maintain - Best-practice approach - Would name it something like blocktype_trb.c or similar to distinguish from protocol-only dissectors - Documentation of a sparsely used feature - We don't like plugins in the main sourcecode cheers Roland On Thu, Mar 1, 2018 at 10:46 AM, Paul Offord <paul.off...@advance7.com> wrote: > Hi Pascal, > > > > Thanks for your note regarding my change 26203 - > https://code.wireshark.org/review/#/c/26203/ . You suggested that I > submit it as a built-in dissector, not a plugin. I’m not keen for two > reasons: > > > > - If it is rejected (and I have a feeling it will be), I’ll then have > to rewrite it to offer as an optional plugin > - I think adding it as a built-in dissector means changes to core > Wireshark code > > > > Why do you think it should be a built-in dissector? > > > > Thanks and regards…Paul > > ______________________________________________________________________ > > This message contains confidential information and is intended only for > the individual named. If you are not the named addressee you should not > disseminate, distribute or copy this e-mail. Please notify the sender > immediately by e-mail if you have received this e-mail by mistake and > delete this e-mail from your system. > > Any views or opinions expressed are solely those of the author and do not > necessarily represent those of Advance Seven Ltd. E-mail transmission > cannot be guaranteed to be secure or error-free as information could be > intercepted, corrupted, lost, destroyed, arrive late or incomplete, or > contain viruses. The sender therefore does not accept liability for any > errors or omissions in the contents of this message, which arise as a > result of e-mail transmission. > > Advance Seven Ltd. Registered in England & Wales numbered 2373877 at > Endeavour House, Coopers End Lane, Stansted, Essex CM24 1SJ > > ______________________________________________________________________ > This email has been scanned by the Symantec Email Security.cloud service. > For more information please visit http://www.symanteccloud.com > ______________________________________________________________________ > > ____________________________________________________________ > _______________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject= > unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
