It depends. Gerrit gives you few suggestions: cherry-pick takes just the
current change, checkout and pull take all the changes in the branch.

On Sat, Apr 14, 2018, 07:45 Anders Broman <a.broma...@gmail.com> wrote:

> I thought picking the last one would include them all as the are in the
> same branch. I'll check, but I might not be able to until Monday.
> Regards
> Anders
>
> Den fre 13 apr. 2018 21:57Dario Lombardo <dario.lombardo...@gmail.com>
> skrev:
>
>> Did you cherry-picked all my rpm changes? there are 3 not merged yet and
>> you need them all.
>>
>> On Fri, Apr 13, 2018, 16:35 Anders Broman <a.broma...@gmail.com> wrote:
>>
>>> Hi,
>>> I have the git repo in /home/ericsson/wireshark/
>>> And build in
>>> /home/ericsson/build/
>>>
>>> In the Build dir I run the cmake command with... /wireshark
>>> And then make rpm-package
>>>
>>> Regards
>>> Anders
>>>
>>> Den fre 13 apr. 2018 15:55Dario Lombardo <dario.lombardo...@gmail.com>
>>> skrev:
>>>
>>>> Can you give me the steps you made?
>>>>
>>>> On Fri, Apr 13, 2018 at 2:09 PM, Anders Broman <
>>>> anders.bro...@ericsson.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Checking out branch:
>>>>>
>>>>> commit c369c295097f4377527e989df1658effb6497735
>>>>>
>>>>> Author: Dario Lombardo <lom...@gmail.com>
>>>>>
>>>>> Date:   Fri Apr 13 08:55:05 2018 +0200
>>>>>
>>>>>
>>>>>
>>>>> I still get:
>>>>>
>>>>> -- The following OPTIONAL packages have not been found:
>>>>>
>>>>>
>>>>>
>>>>> * BCG729 , G.729 decoder , <
>>>>> https://www.linphone.org/technical-corner/bcg729/overview>
>>>>>
>>>>>    Support for G.729 codec in RTP player
>>>>>
>>>>> * DOXYGEN
>>>>>
>>>>> * MaxMindDB
>>>>>
>>>>>
>>>>>
>>>>> fatal: Not a git repository (or any of the parent directories): .git
>>>>>
>>>>> CMake Error at CMakeLists.txt:2934 (string):
>>>>>
>>>>>   string begin index: 1 is out of range 0 - 0
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -- Configuring incomplete, errors occurred!
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>> Anders
>>>>>
>>>>>
>>>>>
>>>>> *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On
>>>>> Behalf Of *Dario Lombardo
>>>>> *Sent:* den 13 april 2018 13:37
>>>>> *To:* Developer support list for Wireshark <
>>>>> wireshark-dev@wireshark.org>
>>>>> *Subject:* Re: [Wireshark-dev] RPM generation
>>>>>
>>>>>
>>>>>
>>>>> With the last changes pushed, I'm able to make openSUSE work. Since
>>>>> this was pointed out as blocking for autotools removal, we can proceed, as
>>>>> soon as Anders confirms.
>>>>>
>>>>> Anyone already working on autotools removal?
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 13, 2018 at 8:49 AM, Dario Lombardo <
>>>>> dario.lombardo...@gmail.com> wrote:
>>>>>
>>>>> Perfect. Centos, Fedora and openSUSE are the three under testing.
>>>>> openSUSE is rather different from the others, and I'm pushing some changes
>>>>> specific for that, trying not to break the others :).
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Apr 13, 2018 at 3:03 AM, Jeff Morriss <
>>>>> jeff.morriss...@gmail.com> wrote:
>>>>>
>>>>> On 04/10/2018 09:14 AM, Dario Lombardo wrote:
>>>>>
>>>>> Is the rpm build platform expected to be one? If yes, which one? If
>>>>> no, do we want to support all the flavors? It seems that different flavors
>>>>> require different package names (link in asciidoctor). I can be hard to be
>>>>> portable in this way.
>>>>>
>>>>>
>>>>> The current RPM build tries to support SUSE and Red Hat/Fedora--the
>>>>> former for Anders and the latter for the rest of the world :-).  I don't
>>>>> recall seeing requests for other distributions.
>>>>>
>>>>> ___________________________________________________________________________
>>>>> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>>>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>>>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>>>             mailto:wireshark-dev-requ...@wireshark.org
>>>>> ?subject=unsubscribe
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ___________________________________________________________________________
>>>>> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>>>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>>>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>>>              mailto:wireshark-dev-requ...@wireshark.org
>>>>> ?subject=unsubscribe
>>>>>
>>>>
>>>>
>>>> ___________________________________________________________________________
>>>> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>>              mailto:wireshark-dev-requ...@wireshark.org
>>>> ?subject=unsubscribe
>>>
>>>
>>> ___________________________________________________________________________
>>> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>              mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>
>>
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>              mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Reply via email to