Hi Richard, Yes, ieee80211 is a big dissector.. I think, it will be may be possible to split some code between multiple file.. May be need to add more comment with the list of supported attribut (or a wiki page with info about the dissector....)
On Thu, Jan 3, 2019 at 6:07 PM Richard Sharpe <realrichardsha...@gmail.com> wrote: > Hi folks, > > I am sure that most people who work on the ieee80211 dissector will > agree that it is a monster that needs taming. > > It is currently more than 37,000 lines long and a number of things > that have been done in it make it hard to split it in rational ways. > > Perhaps the way that the Wi-Fi community does standards also makes > things difficult, but some of the issues I see are: > > 1. TAGs and Extended TAGs (for IEs) have to be defined in > packet-ieee80211.c and thus are hard to split out to other files. > > It would be nice if there was some way to register new tags and > extended tags with errors if you are registering an already registered > value. > > 2. The IE handling code handles placing the TAG and length into the > tree, also forcing the handling of IEs into packet-ieee80211.c. > > It would be better if there was a function to handle the header, that > could perhaps be passed a function pointer to handle the body so we > can spit things out. > > 3. It is damn hard to find fixed fields that have been implemented ... > > And so on. > > I am sure that others can think of further deficiencies. > > It would be useful to compile a list so we can look at reworking the > Wi-Fi suite of dissectors to make them more maintainable over time. > > Please respond with your thoughts. > > -- > Regards, > Richard Sharpe > (何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者) > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
