Pascal: Thank you for taking your time to reply and also to review my merge request. I appreciate it.
I also appreciate that you have expressed the view that it is a shame, if MR is closed. Several clarifications: I have not assumed I am busier than core developers, I have just said I am more busy than most people. I think it is a reasonable expectation that if a person picks up the MR and requests changes, they will follow on the changes. It bothered me that people requested changes but did not have time to review them, or even explicitly said that they will not. That has contributed to my feeling of time being wasted. I have not tried to be aggressive in merging the request. That was not the point -- the point was trying to get a clear indication if the change is considered and will be reviewed. I am fine if the project does not want the changes. I have explained that I am very busy. I need to proceed with the changes for my work needs, and I had to know whether I shall continue to contribute or just proceed locally. -- ---------------------------------------- Constantine Gavrilov Storage Architect Master Inventor Tel-Aviv Storage Lab IDT Lead Tel-Aviv IBM Storage Lab 1 Azrieli Center, Tel-Aviv ---------------------------------------- From: Pascal Quantin <pas...@wireshark.org> To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Date: 03/29/2021 07:13 PM Subject: [EXTERNAL] Re: [Wireshark-dev] Improvments for NVMeOF dissector Sent by: "Wireshark-dev" <wireshark-dev-boun...@wireshark.org> Hi Constantine, Le lun. 29 mars 2021 à 17:36, Constantine Gavrilov <con...@il.ibm.com> a écrit : I have waited for another week and nothing happens. Unfortunately those kinds of things happen sometimes. As said previously we are all doing ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd Hi Constantine, Le lun. 29 mars 2021 à 17:36, Constantine Gavrilov <con...@il.ibm.com> a écrit : I have waited for another week and nothing happens. Unfortunately those kinds of things happen sometimes. As said previously we are all doing this in our spare time, and maybe the previous exchanges did not motivate other people (just speculating here, at least this is how I could have reacted, sorry to say that). This merge request (!2405) was created more than two weeks ago, and the people who have looked into it either lost interest or do not have time. So I took the time to look at it and provided some comments in the merge request. Once those small nits are clarified I guess we can merge the MR. I appreciate that everyone is so busy, but the same claim goes for contributors as well as developers. No one said the opposite. I am more busy than most people, and I have found time to contribute. I equally expect that someone finds time to look into this work. This is a reasonable expectation as long as the projects states that contributions are welcome. If every developer is so busy and there is no formal process to assign the contribution for review, or a measure of how many contributions were evaluated by people holding core developer status, while there is also a taste of coldness in communication -- "do not bother us, we are busy and owe you nothing", why shall I bother? I wonder how you can assume that you are busier than us without having any clue on our own tasks, and being aggressive rarely helps (again this is my personal point of view, not any project statement). I feel I have wasted my time. I have already explained that I have nothing to gain from this. It was an act of gratitude to the project. But I do not want to feel that I have to push it down the project throat. As I have said there are many changes to improve NVMEoF dissector, and if there is no interest nor cooperation, I can easily continue in my local tree and it will serve my work just fine. This also means that these changes will never see public access. No one said that and I'm sorry if you feel this way. The same goes for MR 2522 and 2324. Regarding the last one, I simply fail to grasp what is the problem there. Typically, build problems are solved within minutes (like a recent problem building on MAC). Since the change is so trivial, and beta builds of Fedora with gcc-11 are out, while the release is imminent, I do not understand why it has not been merged. Perhaps the problem is that I have provided the patch and should have just opened the bug report like people did reporting the MAC build issue? So, I want to know what to do. Shall I close the merge requests and leave busy people alone with their busy affairs or perhaps we can work in the spirit of cooperation? It's a shame if you close the MR, but we cannot prevent you from doing it. I guess the first positive step would be to sound less aggressive (maybe that's not the intent, but this is how I read your messages, so maybe others do also). Hope we can move smoothly in the future and that you can accept that things can take time sometimes. Best regards, Pascal. Until this point, I have contributed above 3k lines of code, where 800 lines are in the tree, and 2.2K lines are stuck in the review. If this is not a significant contribution, I do not know what is. I understand responsibility and would not whine about lack of time (despite being very busy) if I had core developer access. Your call, core developers. Can we collaborate, or you are so busy that collaboration is not possible? -- ---------------------------------------- Constantine Gavrilov Storage Architect Master Inventor Tel-Aviv Storage Lab IDT Lead Tel-Aviv IBM Storage Lab 1 Azrieli Center, Tel-Aviv ---------------------------------------- From: Constantine Gavrilov/Israel/IBM To: Developer support list for Wireshark < wireshark-dev@wireshark.org> Date: 03/21/2021 05:37 PM Subject: Re: [EXTERNAL] Re: [Wireshark-dev] Improvments for NVMeOF dissector Pascal, thank you. > You should accommodate the project, and not the other way around. I have never assumed otherwise, just tried to reach out... I will wait until the end of the week and see what happens... -- ---------------------------------------- Constantine Gavrilov Storage Architect Master Inventor Tel-Aviv Storage Lab IDT Lead Tel-Aviv IBM Storage Lab 1 Azrieli Center, Tel-Aviv ---------------------------------------- ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org ?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
