Hi Richard, Indeed it’s a rather monolithic block. Quick look at the code, here are some suggestions .
- Extract the dissection of the fixed management fields. All these add_ff_... functions count up to a lot. Not sure how they are dependant on other parts of the dissector, but these at least one external dependancy. Could change about 10% LOC. - Extract the dissection of tags. These are now modeled as PINOs. Not sure how they are dependant on other parts of the dissector. Not sure how much that would change. - Unwrap lines Lame suggestion, but quite a few lines are wrapped somewhat conservatively. Unwrapping them to 132 columns might save some LOC as well. I can offer help with the last one, the others require a little more insight in this code. Thanks, Jaap > On 3 Dec 2021, at 00:12, Richard Sharpe <realrichardsha...@gmail.com> wrote: > > Hi folks, > > The IEEE802.11 dissector is becoming unwieldy. > > It is currently around 50,000+ lines of code! > > I am adding additional lines of code for the Wi-Fi 7 spec. I dread to > think what will happen when they embark on Wi-Fi 8! > > Is there some way we can split this behemoth into a set of separate files? > > -- > Regards, > Richard Sharpe > (何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者) ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
