On Fri, Jul 19, 2024 at 8:07 PM Guy Harris <ghar...@sonic.net> wrote:
> On Jul 19, 2024, at 2:19 PM, Gerald Combs <ger...@wireshark.org> wrote: > > > The cppcheck warning needs to be fixed, but it looks like the job is > failing due to a change in packet-pkcs12.c: > > > > ---- > > diff --git a/epan/dissectors/packet-pkcs12.c > b/epan/dissectors/packet-pkcs12.c > > index 3412292d..65796bf9 100644 > > --- a/epan/dissectors/packet-pkcs12.c > > +++ b/epan/dissectors/packet-pkcs12.c > > @@ -423,7 +423,7 @@ int PBE_decrypt_data(const char > *object_identifier_id_param _U_, tvbuff_t *encry > > /* add it as a new source */ > > add_new_data_source(actx->pinfo, clear_tvb, name->str); > > - g_string_free(name, true); > > + g_string_free(name, TRUE); > > /* now try and decode it */ > > call_ber_oid_callback(object_identifier_id_param, clear_tvb, 0, > actx->pinfo, tree, NULL); > > ---- > > Not sure what it's diffing there, given that both > epan/dissectors/asn1/pkcs12/packet-pkcs12-template.c and > epan/dissectors/packet-pkcs12.c appear to be passing TRUE to > g_string_free() in the one and only call to g_string_free(). > It's diffing that the MR in question is changing that TRUE to true, but not changing the template in the asn1 directory. John
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
