Am Montag, den 14.07.2008, 19:50 +0200 schrieb Koen Deforche:
> Hey Goetz,
>
> 2008/7/14 Goetz Babin-Ebell <[EMAIL PROTECTED]>:
> > Hello Folks,
> >
> > Index: src/wt/WLogger.C
> > ===================================================================
> > RCS file: /opt/cvs/wt/src/wt/WLogger.C,v
> > retrieving revision 1.1
> > diff -u -r1.1 WLogger.C
> > --- src/wt/WLogger.C 13 Jul 2008 18:15:10 -0000 1.1
> > +++ src/wt/WLogger.C 14 Jul 2008 17:19:13 -0000
> > @@ -144,6 +144,7 @@
> >
> > bool WLogEntry::Impl::quote() const
> > {
> > + if (logger_.fields().empty()) return false;
> > return logger_.fields()[currentField_].isString();
> > }
>
> Although it was a bit assuming, it shouldn't happen unless you are
> trying to create too many fields considering the number of
> WLogger::addField() calls you have done?
I don't use the WLogger at all.
The crash I observed was inside of WT (build with debug info)
backtrace:
#0 0x081eff5c in Wt::WLogger::Field::isString (this=0x0)
at /usr/src/buildenv/wt-cvs-wt/src/Wt/WLogger:84
#1 0x081ef3f5 in Wt::WLogEntry::Impl::quote (this=0x838cd28)
at /usr/src/buildenv/wt-cvs-wt/src/Wt/WLogger.C:148
#2 0x081ef50c in Wt::WLogEntry::Impl::startField (this=0x838cd28)
at /usr/src/buildenv/wt-cvs-wt/src/Wt/WLogger.C:114
#3 0x081efc1a in Wt::WLogEntry::startField (this=0xbfdad728)
at /usr/src/buildenv/wt-cvs-wt/src/Wt/WLogger.C:102
#4 0x081656ed in Wt::WLogEntry::operator<< <char> (this=0xbfdad728,
t=91 '[') at /usr/src/buildenv/wt-cvs-wt/src/Wt/WLogger:186
#5 0x081efeda in Wt::WLogEntry::operator<< (this=0xbfdad728)
at /usr/src/buildenv/wt-cvs-wt/src/Wt/WLogger.C:59
#6 0x0815f8b3 in http::server::Configuration::log (this=0x838ccb0,
[EMAIL PROTECTED])
at /usr/src/buildenv/wt-cvs-wt/src/http/Configuration.C:248
#7 0x08168fc6 in Server (this=0x83a8e90, [EMAIL PROTECTED],
[EMAIL PROTECTED]) at /usr/src/buildenv/wt-cvs-wt/src/http/Server.C:75
#8 0x0815b9c2 in Wt::WServer::start (this=0xbfdada98)
at /usr/src/buildenv/wt-cvs-wt/src/http/WServer.C:140
#9 0x0815c4ce in Wt::WRun (argc=14, argv=0xbfdadb48,
createApplication=0x8090568 <createApplication(Wt::WEnvironment
const&)>) at /usr/src/buildenv/wt-cvs-wt/src/http/WServer.C:230
#10 0x0809036d in main (argc=10, argv=0xbfdaded4) at main.C:373
> If not, there is a bug ?
It seems that way...
> If so, then, yes, perhaps it is okay to relax the constraint and allow
> to add fields to a logger which haven't been explicitly declared --
> but it is perhaps not a good idea?
I didn't dig too deep in the code, so I've not completely figured out
what you were doing there...
Bye
Goetz
--
Goetz Babin-Ebell <[EMAIL PROTECTED]>
4G Systems GmbH & Co KG
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
witty-interest mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/witty-interest