On Tue, Dec 9, 2008 at 2:41 PM, Koen Deforche <[EMAIL PROTECTED]> wrote: > Hey Pau, > > 2008/12/7 Pau Garcia i Quiles <[EMAIL PROTECTED]>: >> Hello, >> >> While packaging Wt 2.2.2 for Debian, I've noticed it sets its version >> information to 2.2.1: >> >> In wt-2.2.2/CMakeLists.txt: >> >> SET(VERSION_MINOR 1) >> >> It should have been: >> >> SET(VERSION_MINOR 2) >> >> The soversions are also unchanged from 2.2.1: >> >> SET(WT_SOVERSION 9) >> SET(WTEXT_SOVERSION 6) >> SET(WTHTTP_SOVERSION 4) >> SET(WTFCGI_SOVERSION 4) >> >> But: >> - WT_SOVERSION should have been bumped to 10 due to several changes >> here and there >> - *Maybe* WTHTTP_SOVERSION should have been bumped to 5 due to changes >> on Win32 in WServer.C. I'm not really sure of this one: in the source >> what I see is mostly a change in the layout of the file due to >> #ifdef's and code reorganization. There are no new exported methods >> and I think the code reorganization has not affected the vtable but to >> be fully sure, I'd need to check the symbols tables on Win32. >> Unfortunately, I won't have access to a computer with Windows until >> Tuesday. > > You are right about the WT_SOVERSION (and VERSION_MINOR too). Feel > free to make these changes for debian -- we will make sure we bump the > WT_SOVERSION to 11 for the next release. > > I do not think we need to bump WTHTTP_SOVERSION, since as you say, > nothing changed in that API or layout that causes binary > incompatibility.
Perfect, I'll do that. Lintian (a Valgrind-like tool for Debian packaging) found this issue: X: witty: shlib-calls-exit usr/lib/libwthttp.so.2.2.2 N: N: The listed shared library calls the C library exit() or _exit() N: functions. N: N: In the case of an error, the library should instead return an N: appropriate error code to the calling program which can then determine N: how to handle the error, including performing any required clean-up. N: N: In most cases, removing the call should be discussed with upstream, N: particularly as it may produce an ABI change. The exit() call is present in src/http/HTTPStream.C and src/http/Configuration.C -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer) ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ witty-interest mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/witty-interest
