Bugs item #1544057, was opened at 2006-08-21 09:15 Message generated for change (Comment added) made by derekc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1544057&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: light Group: v2.0 Status: Open Resolution: None Priority: 5 Submitted By: koffeinkick (koffeinkick) Assigned to: Derek (derekc) Summary: Patchgroup attribute causes installation to fail Initial Comment: By adding the PatchGroup attribute to files, it is to my understanding the case that these files are added to the end of the file sequence. Thereby it is ensured that the file sequence is not changed between versions. However, it appears that Wix still requires files to be added to the end of the compilation/linking process anyway. Please see the attached wxs file for more information. The file contains three components, one of which has the PatchGroup attribute set to "1". When this component is specified last, everything works fine. However, if it is specified second to last, the installation fails with the message "The file 'new.txt' cannot be installed because the file cannot be found in cabinet file 'Product.cab'." My guess is that Wix generates the cab file in a different order than the file sequence numbers are indicating. ---------------------------------------------------------------------- >Comment By: Derek (derekc) Date: 2006-08-22 01:00 Message: Logged In: YES user_id=518766 Another mitigating factor is that patch-added files must always occur at the end of the sequence, so if there are multiple media in a product and the patched files occur on any media other than the last one, the patched files must be part of a new media. So, there are many scenarios in which a patched file will occur in its own media at the end of the sequence (in which case this bug won't be a problem). ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-08-22 00:57 Message: Logged In: YES user_id=518766 Ok, so this is an interesting bug. I was trying to figure out why this problem wasn't discovered before since it seems like it would completely break patching. But that's just it - this has no adverse impact on patching. What this bug breaks is the upgraded MSI built for patching but not the patch which would be generated by PatchWiz. Here's why: the cabinet created by WiX is incorrect for running the MSI directly. However, when a patch file is created, it contains its own embedded cabinet which would have the files in the correct order since they are ordered by the sequence information (which is currently correct). So basically, this is a great bug to fix but doesn't actually break any scenario besides just trying to run the upgraded.msi directly (which you shouldn't be doing because its created so that a patch can be generated off the difference of it and a target msi). At any rate, this is probably serious enough to merit fixing in WiX 2.0, so the fix should be in this week's release (WiX 3.0 will also be fixed). ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-08-22 00:23 Message: Logged In: YES user_id=518766 You're right. Here's what's happening. The file sequence is set properly but the sequence of files in the cabinet is wrong. I'm investigating now. ---------------------------------------------------------------------- Comment By: koffeinkick (koffeinkick) Date: 2006-08-22 00:05 Message: Logged In: YES user_id=1175806 I'm building a new version of a msi file, which includes some new components and files. The old msi file will be patched to the new one. At the same time, the new msi-file will be released separately as well. To my understanding, this means that the new files must be added to the end of the file sequence? Please correct me if I'm wrong! I am assuming that the msi file used to create the patch should be the same as the one that is released separately? ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-08-21 12:43 Message: Logged In: YES user_id=518766 Why are you using PatchGroup? It is only for creating updated msi images for patch generation. Any other usage probably won't work. ---------------------------------------------------------------------- Comment By: koffeinkick (koffeinkick) Date: 2006-08-21 09:17 Message: Logged In: YES user_id=1175806 I'm using version 2.0.4415.0 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1544057&group_id=105970 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
