Bugs item #1420636, was opened at 2006-01-31 16:51
Message generated for change (Comment added) made by fregro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1420636&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: extensions
Group: v2.0
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Paul Gunn (paulgunn)
Assigned to: Fredrik Grohn (fregro)
Summary: Null pointer reference in com+ custom action

Initial Comment:
The symptom is:
ConfigureComPlusUninstall:  Debug Assert Message: 
Assertion failed in
 c:\documents and settings\robmen\local
 settings\temp\wp001\src\ca\wcautil\wcautil.cpp, 64
 CustomAction ConfigureComPlusUninstall called 
WcaInitialize() but not
 WcaTerminate()

at which point installation rolls back.

I debugged the problem and found a defect in 
cpiasmsched.app in the SortAssemblyListByModule 
function.

At line 1230 you have the following:

// if the item is not already first in the list
if (!pAsm->pPrev)
{
  // remove item from it's current position
  pAsm->pPrev->pNext = pAsm->pNext; //EXCEPTION!!
  ...

As you can see pAsm->pPrev is dereferenced (pAsm-
>pPrev->pNext) after it was established to be a null 
pointer (!pAsm->pPrev). 

Based on the comment and subsequent code, it looks 
like the 'if' check is reversed from what it should 
be. I think it should be:

// if the item is not already first in the list
if ( NULL != pAsm->pPrev) //CHECK IF NOT NULL
{
  // remove item from it's current position
  pAsm->pPrev->pNext = pAsm->pNext; 
  ...

After this change, everything worked fine. I think 
this code is only exercised when used from a merge 
module. That would explain why not many people have 
encountered it.




----------------------------------------------------------------------

>Comment By: Fredrik Grohn (fregro)
Date: 2006-08-26 02:06

Message:
Logged In: YES 
user_id=1138467

Should be fixed in 2.0.4423.0.

----------------------------------------------------------------------

Comment By: Antony Walmsley (antonywa)
Date: 2006-02-02 16:17

Message:
Logged In: YES 
user_id=1345213

I noticed this also :

http://sourceforge.net/mailarchive/forum.php?thread_id=9502039&forum_id=39978

Strangely, it only happened when using the merge module in
an Installshield project. A WiX installer worked fine.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1420636&group_id=105970

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to