Bugs item #1485236, was opened at 2006-05-10 03:15 Message generated for change (Settings changed) made by barnson You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1485236&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: heat Group: v3.0 >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: James Carter (carterja) Assigned to: Derek (derekc) >Summary: Heat throws \"System.Exception\" if file ids go beyond 999 Initial Comment: When using the directory harvester of heat.exe 3.0.1621.0 against a directory that contains more than 999 files (as specified on line 125 of MutatorExtension.cs) an exception of type "System.Exception" is thrown. The source line specified above corresponds to the "GetIdentifer" method of the "MutatorExtension.IdentifierGenerator" class. Excerpt from wix fragment generated by heat: <ComponentRef Id="File_999" /> In order to get the following: <ComponentRef Id="File_1000" /> I had to patch the line: "for (int i = 0; i < 999; i++)" with "for (int i = 0; i < 9999; i++)" just to verify the problem. Not sure why 999 was chosen as the upper limit for this loop. Perhaps due to the limit on the Id column of the File table? -James ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-05-16 20:06 Message: Logged In: YES user_id=518766 Ok, so two fixes were made here: 1. It now supports up to Int32.MaxValue (which should be plenty). 2. If a file name is completely numeric, it will prepend "File" and use the numeric name afterwards. ---------------------------------------------------------------------- Comment By: James Carter (carterja) Date: 2006-05-10 18:05 Message: Logged In: YES user_id=1455027 ReSharper generates a number of files who's names are completely numeric. These files were left in my build directory by mistake, and thus exposed the issue when I ran heat against it. For example, just one ReSharper directory contained files sequentially named starting at "0" and up to "3776". ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-05-10 07:36 Message: Logged In: YES user_id=518766 What do the file names of the files in that directory look like? Heat should only use File_* if it can't find any valid characters in the file names (for example if the file names were completely numeric or localized characters). I'll also work on increasing that limit and catching the case of too many files, but I'm curious how this scenario happened at all. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1485236&group_id=105970 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
