Bugs item #1739194, was opened at 2007-06-18 18:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1739194&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: extensions
Group: v3.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Adam Strzelecki (ono)
Assigned to: Scott Kurtzeborn (scotk)
Summary: XmlFile|Config doesn't preserve existing XML format

Initial Comment:
Hi Devs,

XmlFile|XmlConfig actions when changing existing files are reformatting them 
using tab indention, causing the whole file content to differ.
Please use pixd->put_preserveWhiteSpace(VARIANT_TRUE) as in attached patch (see 
attachments) for every time you open file with IXMLDOMDocument.

Alternatively you can setup whitespace preservation as a parameter to 
XmlFile|XmlConfig, but I think if you at least respect actual XML file format 
this would be enough and make happy all WiX users.

Note: Even Microsoft and you don't use tabs for XML formatting of your files.. 
so forcing XML to be indented with tabs when doing XmlFile is IMHO a bug.

I'm jabberd2 (XMPP service daemon) Windows version maintainer. Currently I'm 
preparing advanced installer of jabberd2 using WiX. I'm using XmlFile to change 
some entries on XML config files on setup.

Jabberd config files are quite complicated and having lots of comments, lots of 
commented out sections, etc. And most important thing they're not using tab 
indention as it is by default in MSXML.

After XmlFile does the change, and because preserveWhiteSpace of XMLDOMDocument 
is off, it does reformat of all into the tabbed indention, ruining the whole 
outline of commented out sections, and making the file look different.

This is major showstopper for me, cause XML files are heart of jabberd2, so now 
I'm using my custom built WiX with the patch below.

I'd be glad if you update the WiX with proposed changes (or any close 
alternative), so anybody else that's building jabberd2 have the same MSI output 
file as me.

See attached patch,

Thanks for great WiX!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1739194&group_id=105970

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to