Bugs item #1757835, was opened at 2007-07-20 15:24
Message generated for change (Settings changed) made by pmarcu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1757835&group_id=105970
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: light
Group: v3.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ken (kenmuse)
>Assigned to: pmarcu (pmarcu)
Summary: DefaultLanguage/DefaultVersion ignored (+fix)
Initial Comment:
May be related to issue 1666461 and is the cause of the issue noted about ttf
files not getting the proper language. There's a logic issue that can prevent
DefaultLanguage and DefaultVersion from being used. There is no workaround
unless you suppress file info and manually version every file in your project.
In wix\Binder.cs UpdateFileInformation, section of code starting at line 2204
which occurs if you have not set suppressFileHashAndInfo (so that candle can
get the version from the file):
If the file exists, the version and language are retrieved from the file using
Installer.GetFileVersion. If version and language returned are empty (line
2228), the file is hashed.
If the file has a version, but no language (such as many TTF's), the logic
falls through to line 2260:
fileRow.Version = version;
fileRow.Language = language;
Instead of returning to the default value if no value was returned for
"version" or "language", the Binder sets row's value to empty instead of the
default value. In these cases, the logic prevents the stated functionality from
working for any file which exists and has either version data or language data
but not both.
Solution is to replace the else ("update the file row with the version and
language info"):
else
{
if (0 != version.Length)
{
fileRow.Version = version;
}
if (0 != language.Length)
{
fileRow.Language = language;
}
}
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1757835&group_id=105970
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs
