Bugs item #1824858, was opened at 2007-11-02 12:58 Message generated for change (Settings changed) made by pmarcu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1824858&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: candle Group: v3.0 Status: Open Resolution: None Priority: 5 Private: No Submitted By: ericbaud (ericbaud) >Assigned to: pmarcu (pmarcu) Summary: Font Localization not supported in the WXL file Initial Comment: Hello, Font Size and Font FaceName are usually Language dependent. With the new wix schema localized resource are pushed to the WXL file so it make sense to also support the font style localization. Unfortunately when we try to do this the compiler does not like it because the Font Attributes are being validated before the linker process. Open the bug. If you really want it fixed quickly, feel free to jump in the code. We’d be happy to have the fix. From: Eric Baudouin Sent: Friday, November 02, 2007 09:06 To: Peter Marcu; Aaron Stebner; Bob Arnson; Fredrik Grohn; Joe Abbott; John Lyon-Smith; Jordan Fitzgibbon; Justin Rockwood; Mike Holcomb; Reid Gustin; Rob Mensching; Robert Flaming; Scott Kurtzeborn Cc: Paul Houldridge Subject: RE: [WiX-users] Font definition and WXL Well then this is a bug. We should be able to localize those, unless you have another approach. Font localization is a common problem. We could write a script that preprocess the wix file by bypassing candle, but I was hoping that there would be a solution coming out of the box. Thank you. E. From: Peter Marcu Sent: Friday, November 02, 2007 9:00 AM To: Eric Baudouin; Aaron Stebner; Bob Arnson; Fredrik Grohn; Joe Abbott; John Lyon-Smith; Jordan Fitzgibbon; Justin Rockwood; Mike Holcomb; Reid Gustin; Rob Mensching; Robert Flaming; Scott Kurtzeborn Cc: Paul Houldridge Subject: RE: [WiX-users] Font definition and WXL Those attributes are not localizable attributes. Therefore !(loc variables will not be replaced in them. From: Eric Baudouin Sent: Friday, November 02, 2007 8:52 AM To: Aaron Stebner; Bob Arnson; Fredrik Grohn; Joe Abbott; John Lyon-Smith; Jordan Fitzgibbon; Justin Rockwood; Mike Holcomb; Peter Marcu; Reid Gustin; Rob Mensching; Robert Flaming; Scott Kurtzeborn Cc: Paul Houldridge Subject: FW: [WiX-users] Font definition and WXL Hello, I am also forwarding this question to your team. Thank you for letting us know if you have any ideas on how to resolve this. Thank you very much. E. From: Paul Houldridge Sent: Friday, November 02, 2007 8:18 AM To: Eric Baudouin; Kelly Leahy Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: RE: [WiX-users] Font definition and WXL I actually rewrote the code for the last test. If you look at the original example the names match. However, after trying a few more things, it looks like the FaceName attribute takes the localized string just fine. It’s the Size and Bold attributes that are not preprocessing the localized string. Look at the original errors below. Paul From: Eric Baudouin Sent: Thursday, November 01, 2007 5:20 PM To: Kelly Leahy Cc: Paul Houldridge; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: RE: [WiX-users] Font definition and WXL Not a bad suggestion Paul would you mind to have a look at this, in case the linker is case sensitive. Thank you. E. From: Kelly Leahy [mailto:[EMAIL PROTECTED] Sent: Thursday, November 01, 2007 4:59 PM To: Eric Baudouin Cc: Paul Houldridge; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [WiX-users] Font definition and WXL Ok... It also appears that your error message says 'Facename' (lowercase 'N'), but your declaration shows an uppercase. Not sure if it matters, just thought I'd mention it since I noticed it. Kelly Eric Baudouin <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 11/01/2007 04:44 PM To Kelly Leahy <[EMAIL PROTECTED]> cc "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>, Paul Houldridge <[EMAIL PROTECTED]>, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> Subject Re: [WiX-users] Font definition and WXL Here is the answer from Paul, so it look like syntaxically speaking we were doing the right thing. So I think we need to focus more on the methodology. Thank you anyway for your reply. No luck. Using the ! instead of the $ is right. $ is deprecated. .\SetupUI.wix(26) : warning LGHT1073 : The localization variable $(loc.BannerTextStyle_Facename) uses a deprecated prefix '$'. Please use the '!' prefix instead. Since the prefix '$' is also used by the preprocessor, it has been deprecated to avoid namespace collisions. warnings in directory c:\drs_sync_1\sql\sync\src\setup\core c:\drs_sync_1\sql\sync\src\setup\core\setupui.wix(26) : warning LGHT1073 : The localization variable $(loc.BannerTextStyle_Facename) uses a deprecated prefix '$'. Please use the '!' prefix instead. Since the prefix '$' is also used by the preprocessor, it has been deprecated to avoid namespace collisions. .\SetupUI.wix(26) : error LGHT0102 : The localization variable !(loc.BannerTextStyle_Facename) is unknown. Please ensure the variable is defined. errors in directory c:\drs_sync_1\sql\sync\src\setup\core c:\drs_sync_1\sql\sync\src\setup\core\setupui.wix(26) : error LGHT0102 : The localization variable !(loc.BannerTextStyle_Facename) is unknown. Please ensure the variable is defined. NMAKE : fatal error U1077: 'C:\DRS_SYNC_1\Tools\wix3\light.exe' : return code '0x66' NMAKE : fatal error U1077: 'C:\DRS_SYNC_1\Tools\wix3\light.exe' : return code '0x66' Stop. From: Kelly Leahy [mailto:[EMAIL PROTECTED] Sent: Thursday, November 01, 2007 4:31 PM To: Eric Baudouin Cc: Paul Houldridge; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [WiX-users] Font definition and WXL Don't you want $(loc.BannerTextStyle_Size) not !(loc.BannerTextStyle_Size)? Kelly Eric Baudouin <[EMAIL PROTECTED]> Sent by: [EMAIL PROTECTED] 11/01/2007 04:17 PM To "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> cc Paul Houldridge <[EMAIL PROTECTED]> Subject [WiX-users] Font definition and WXL Hello, We have moved our resource to a wxl file to facilitate the localization of our component. In the localization world it is a good practice to make sure that the font size and the font facename can be localized. I was hoping that I could move the font style attribute in the WXL as well so that the localization team could change it accordingly, since the font size and the font facename are different for the Japanese, or any far-east languages. Unfortunately as you can see down below replacing the font attribute with the WXL loc ID causes the compiler to break, because the preprocessor might run some validation because linked the loc data in the code. Would you have a different approach we could use so that at least we have a work-around. Thank you very much. E. <wixloc:String Id="BannerTextStyle_FaceName">MS Sans Serif</wixloc:String> <wixloc:String Id="BannerTextStyle_Size">12</wixloc:String> <wixloc:String Id="BannerTextStyle_Bold">yes</wixloc:String> Then within my <UI> tag I have: <TextStyle Id="BannerTextStyle" FaceName="!(loc.BannerTextStyle_FaceName)" Size="!(loc.BannerTextStyle_Size)" Red="0" Green="0" Blue="0" Bold="!(loc.BannerTextStyle_Bold)"/> The error I get indicates that the !(loc.name) syntax does not work within the attributes for TextStyle. The loc variables are not getting processed into the defined values. This is the error I get: errors in directory c:\harmonica\sql\sync\src\setup\core c:\harmonica\sql\sync\src\setup\core\setupui.wix(26) : error CNDL0008 : The TextStyle/@Size attribute's value, '!(loc.BannerTextStyle_Size)', is not a legal integer value. Legal integer values are from -2,147,483,648 to 2,147,483,647. c:\harmonica\sql\sync\src\setup\core\setupui.wix(26) : error CNDL0015 : The TextStyle/@Bold attribute's value, '!(loc.BannerTextStyle_Bold)', is not a legal yes/no value. The only legal value is 'no' or 'yes'. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/_______________________________________________ WiX-users mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/wix-users ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1824858&group_id=105970 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
