Bugs item #1719357, was opened at 2007-05-15 11:01
Message generated for change (Comment added) made by tpaxatb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1719357&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: msbuild
Group: v3.0
>Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Doug S (tpaxatb)
Assigned to: pmarcu (pmarcu)
Summary: CoreClean blindly deletes all previously built files

Initial Comment:
The target CoreClean in wix.targets will blindly delete ALL files that had been 
previously built, even if that file is outside of the current build directory 
structure (i.e. is in a different project configuration).  This means that if I 
do a REBUILD of a Debug configuration and then a Release configuration, the 
Release configuration will delete all of the DEBUG configuration's files 
(because the DEBUG configuration wrote those filenames to the 
BaseIntermediateOutputPath\CleanFile, which is shared amongst all 
configurations.

3.0.2911.0

----------------------------------------------------------------------

>Comment By: Doug S (tpaxatb)
Date: 2008-01-31 09:46

Message:
Logged In: YES 
user_id=1342505
Originator: YES

This is "almost" fixed.  However, what now happens is that the file list
is always deleted, regardless of whether there are still files in the list.
 So while other configurations builds are not blindly deleted, they are not
able to be cleaned when one configuration has been cleaned.  The file list
needs to remain around unless it is empty.

To repeat issue (VS 2005, WiX build 3725):

Create WiX project
Build debug configuration
Change configuration to release
Build release configuration
Clean release configuration (note file list in obj directory deleted
here)
Change to debug configuration
Clean debug configuration <-- here is the issue, the debug configuration
is not cleaned.

----------------------------------------------------------------------

Comment By: Doug S (tpaxatb)
Date: 2007-11-15 09:19

Message:
Logged In: YES 
user_id=1342505
Originator: YES

FYI since I haven't seen this fixed, the attached XML fixes the situation.
 Note that what *I* do is put this in a separate file next to my project
file.  Then in each of my .wixproj files I add the following so that it's
read in before the main wix targets file.  Ideally this would be put into
the main wix targets file.  (This behavior ripped from how Csharp projects
does it).

  <!-- The following three lines added to read in a "better" CoreClean
target that fixes bug 1719357 -->
  <PropertyGroup>
   
<CustomAfterWixTargets>$(MSBuildProjectDirectory)\CustomAfterWix.targets</CustomAfterWixTargets>
  </PropertyGroup>
  <Import
Project="$(MSBuildExtensionsPath)\Microsoft\WiX\v3.0\Wix.targets" />


File Added: CustomAfterWix.targets

----------------------------------------------------------------------

Comment By: pmarcu (pmarcu)
Date: 2007-10-01 14:12

Message:
Logged In: YES 
user_id=1612676
Originator: NO

ccampbell, do you still have fixes you would like to contribute? If so,
let me know.

----------------------------------------------------------------------

Comment By: Craig Campbell (ccampbell)
Date: 2007-05-21 20:06

Message:
Logged In: YES 
user_id=188467
Originator: NO

I have been working on integrating wix 3.0 with our current build process.
 I have also found several problems with the way the wix.targets file
builds the wix project.  I've made a few changes that I would like to
submit back to the project if there is some interest.  

The changes consist of aligning the current wix.targets file more closely
to the other language specific targets files (i.e.
Microsoft.CSharp.targets) in that we leverage the Microsoft.Commons.targets
file and reuse several of their utility targets such as
ResolveProjectReferences, CopyFilesToOuputDirectory, Pre/Post build events.
 This has allowed a more consistent integration point for custom build
steps to happen before and after the core build steps.

Oh, and it also fixes the deleting of other configuration builds problem
as well.

--Craig

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1719357&group_id=105970

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to