Bugs item #1793561, was opened at 2007-09-12 15:31 Message generated for change (Comment added) made by micarls You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1793561&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: v3.0 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: sbonev (sbonev) Assigned to: pmarcu (pmarcu) Summary: Torch should give a warning when -x is not used Initial Comment: The -x switch on Torch is used to extract embedded binaries and then diff them. If the -x switch is not passed, then this extraction/diffing does not occur. Torch should warn the user if an MSI contains embedded binaries but the -x switch was not provided. The impact is that the user would assume that their patch was created successfully including changes that were made to embedded binaries when in fact, the embedded binaries are not patched. ---------------------------------------------------------------------- >Comment By: Mike Carlson (micarls) Date: 2008-05-01 22:32 Message: Logged In: YES user_id=2057970 Originator: NO This was fixed a few months ago, and should already be working in recent versions. Apologies for the late resolution. ---------------------------------------------------------------------- Comment By: jordanf (jrfitzgi) Date: 2007-09-13 14:11 Message: Logged In: YES user_id=1672802 Originator: NO It looks like Torch is building invalid wixmst's from diffing two admin images when (a) there is an embedded binary and (b) the Torch -x switch is not used. The result is an unhelpful error message by Pyro (see Repro Steps). The workaround is to always use the -x switch when running Torch. Repro: 1. Build target and upgrade admin images which contain an embedded binary in the Binary table 2. Build a wixmst (mst in wixout format) from the admin images with Torch using the -a switch but not the -x switch 3. Build a patch with Pyro using the wixmst created in step 2. Expected: A proper patch is built, but changes to the Binary table are not in the patch since the -x switch was not passed Actual: Pyro fails with the error: C:\...Temp\c83ehdds\patch.msp : error PYRO0103 : The system cannot find the file 'C:\...\Temp\c83ehdds\patch.msp' with type ''. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1793561&group_id=105970 ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
