Bugs item #1814254, was opened at 2007-10-16 02:52
Message generated for change (Comment added) made by barnson
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1814254&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: candle
Group: v2.0
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jan Brabec (janbrabec)
Assigned to: pmarcu (pmarcu)
Summary: Registry permissions are not reverted to the original state 

Initial Comment:
Hi,

I have a small problem during major upgrade with Registry/Permission element. I 
have created a very simple example replicating the problem, the sources are 
below. 

Steps to recreate:

1. In msi version 1 I create registry key and add some permission to it for 
"NetworkService" user. 
2. In msi version 2 I update the same registry key and I also have the same 
permission tag there. Also in this second msi I have a condition which always 
triggers the rollback (to simulate the problem I have in my real life msi) 3. 
Install the msi version 1 4. Install the msi version 2 over it -> major upgrade 
-> forced rollback

5. After the rollback, the system is not restored to the exact state as it was 
before installation of the msi version 2. The permissions are deleted! So they 
are reverted to the state before installation of the msi version 1.

----------------------------------------------------------------------
The first msi source:
----------------------------------------------------------------------
<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2003/01/wi";>
    <Product Id="????????-????-????-????-????????????" Name="Permission Test" 
Language="1033" Version="2.0.0"
             UpgradeCode="4086DDFE-9912-425F-835D-0ACD310BD9DE"
Manufacturer="TestCompany" >
        <Package Id="????????-????-????-????-????????????"
ShortNames="no" InstallerVersion="200"
                 Compressed="yes" Manufacturer="TestCompany" />

        <Media Id="1" Cabinet="PermissionTest.cab" EmbedCab="yes" />

        <Directory Id="TARGETDIR" Name="SourceDir">
            <Component Id="RegistryComp" DiskId="1"
Guid="EADA08EB-14F1-44bf-962F-A7FEDB7B8D94">
                <Registry Action="write" Type="string"
Key="SOFTWARE\PermissionTest" Name="Test" Value="2.0.0" Root="HKLM" >
                    <Permission GenericAll='yes' EnumerateSubkeys='yes'
CreateSubkeys='yes' Extended='yes' User='NetworkService' />
                </Registry>
            </Component>
        </Directory>

        <Upgrade Id="4086DDFE-9912-425F-835D-0ACD310BD9DE">
            <UpgradeVersion OnlyDetect="no" Property="UPGRADE"
IncludeMinimum="yes" IncludeMaximum="no" MigrateFeatures="yes"
IgnoreRemoveFailure="no"
                            Minimum="1.0.0" Maximum="2.0.0" />
        </Upgrade>

        <!-- Sequence of install actions -->
        <InstallExecuteSequence>
            <RemoveExistingProducts After="InstallInitialize"
>UPGRADE</RemoveExistingProducts>
        </InstallExecuteSequence>

        <Feature Id="Complete" Title="PermissionTest" Level="1"
TypicalDefault="install" Absent="disallow" 
                 AllowAdvertise="no">
            <ComponentRef Id="RegistryComp"/>
        </Feature>

        <Property Id='ALLUSERS' Value='1' />
    </Product>
</Wix>

----------------------------------------------------------------------
The second msi source:
----------------------------------------------------------------------
<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2003/01/wi";>
    <Product Id="????????-????-????-????-????????????" Name="Permission Test" 
Language="1033" Version="2.0.1"
             UpgradeCode="4086DDFE-9912-425F-835D-0ACD310BD9DE"
Manufacturer="TestCompany" >
        <Package Id="????????-????-????-????-????????????"
ShortNames="no" InstallerVersion="200"
                 Compressed="yes" Manufacturer="TestCompany" />

        <Media Id="1" Cabinet="PermissionTest.cab" EmbedCab="yes" />

        <Directory Id="TARGETDIR" Name="SourceDir">
            <Component Id="RegistryComp" DiskId="1"
Guid="EADA08EB-14F1-44bf-962F-A7FEDB7B8D94">
                <Registry Action="write" Type="string"
Key="SOFTWARE\PermissionTest" Name="Test" Value="2.0.1" Root="HKLM" >
                    <Permission GenericAll='yes' EnumerateSubkeys='yes'
CreateSubkeys='yes' Extended='yes' User='NetworkService' />
                </Registry>
            </Component>
        </Directory>

        <Upgrade Id="4086DDFE-9912-425F-835D-0ACD310BD9DE">
            <UpgradeVersion OnlyDetect="no" Property="UPGRADE"
IncludeMinimum="yes" IncludeMaximum="no" MigrateFeatures="yes"
IgnoreRemoveFailure="no"
                            Minimum="1.0.0" Maximum="2.0.1" />
        </Upgrade>

        <CustomAction Id='ForceRollback' Error='Forced Rollback' />

        <!-- Sequence of install actions -->
        <InstallExecuteSequence>
            <RemoveExistingProducts After="InstallInitialize"
>UPGRADE</RemoveExistingProducts>
            <Custom Action="ForceRollback" Sequence="4001">1</Custom>
        </InstallExecuteSequence>

        <Feature Id="Complete" Title="PermissionTest" Level="1"
TypicalDefault="install" Absent="disallow" 
                 AllowAdvertise="no">
            <ComponentRef Id="RegistryComp"/>           
        </Feature>

        <Property Id='ALLUSERS' Value='1' />
    </Product>
</Wix>

----------------------------------------------------------------------


I have also tried it in Wix 3.0.3221 with the same result (using the 
UtilExtension)

Thanks

Jan Brabec
Radiant Systems


----------------------------------------------------------------------

>Comment By: Bob Arnson (barnson)
Date: 2008-05-02 06:35

Message:
Logged In: YES 
user_id=26581
Originator: NO

This was fixed a couple of months ago.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1814254&group_id=105970

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to