Feature Requests item #1968844, was opened at 2008-05-21 08:14 Message generated for change (Comment added) made by jasongin You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642717&aid=1968844&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: dtf Group: None Status: Open Priority: 5 Private: No Submitted By: Christopher Painter (chrpai) Assigned to: Jason Ginchereau (jasongin) Summary: IL Validation Improvements Initial Comment: MakeSfxCA.exe seems to be able to generate a message "No Custom Action Entry Points found in module" I was recently working on project with multiple class files. Everything compiled but failed to run. When I set the first .cs to No Build I suddenly saw the above message and realised that my method wasn't marked static. I fixed that and all was ok. It would be useful if something ( perhaps MakeSfxCA.exe ) did additional validation against the code or IL and generate additional warnings or errors to help developers not do stupid things like I did. Perhaps validate that all methods with [CustomAction] attributes do in fact belong to public classes, are marked public and static and return and accept the correct types. Or maybe there is already a technique I'm not using that would help. Then again, if I'm not using it.... odds are other rookies aren't also. ---------------------------------------------------------------------- >Comment By: Jason Ginchereau (jasongin) Date: 2008-05-21 09:03 Message: Logged In: YES user_id=2086430 Originator: NO MakeSfxCA.exe does currently validate that methods marked with [CustomAction] are public and static, however if that validation fails for a method it just skips the method (does not export it) rather than reporting an error. It doesn't currently check the parameter or return type, although the CA will fail at runtime if those are wrong. I agree that descriptive error messages for invalid custom action methods would certainly be helpful. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642717&aid=1968844&group_id=105970 ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
