Bugs item #1904406, was opened at 2008-02-28 18:44
Message generated for change (Comment added) made by robmen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1904406&group_id=105970

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: extensions
Group: v3.0
>Status: Pending
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Eric StJohn (ericstj)
>Assigned to: Rob Mensching (robmen)
Summary: Perfcounter creation fails when name contains special chars

Initial Comment:
When a PerformanceCategory is created with a PerformanceCounter that has a name 
containing square brackets [Something], the brackets are not escaped in the 
registry entries created by UtilExtension.  This causes whatever is inbetween 
the brackets to disappear when added to the registry because windows installer 
treats it like a property.  One could work around this by defining a property 
called Something="[Something]" but this doesn't work if whatever is inbetween 
the brackets contains a space. 

Additionally the .ini & .h files created may contain incorrect identifiers 
beyond just the [ and ] characters.  It is not clear from MSDN documentation 
what characters are acceptable.  .NET generates generic identifiers:
#define OBJECT_1 0;
#define DEVICE_COUNTER_1 2;
#define DEVICE_COUNTER_2 4;
#define DEVICE_COUNTER_3 6;
#define DEVICE_COUNTER_4 8;
It would probably be wise to do the same.

----------------------------------------------------------------------

>Comment By: Rob Mensching (robmen)
Date: 2008-05-22 23:22

Message:
Logged In: YES 
user_id=991639
Originator: NO

Should escape everything correctly now.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1904406&group_id=105970

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to