It does look like the pyro code doesn't add in the semi-colon separated string for target product codes, the code is there to create the string but the list used to create the string doesn't get updated with information from the wixinstancetransforms table. If I make sure that pyro creates the correct string the patch will work. Attached is the change that should populate all of the product codes, forgive me if this addition is in the wrong location, haven't had time to dive completely into the source.
I would have assumed that ignoring the ProductId in the Validate element would have worked as well but either WiX doesn't set this property correctly or the windows installer doesn't like it. Matt On Mon, Dec 8, 2008 at 12:05 PM, Peter Marcu <[EMAIL PROTECTED]>wrote: > I believe we likely missed adding the instances to the TargetProductCode > when we we added support for instances. However, based on the Patch > authoring I see below, you are ignoring the ProductId in the patch using > the Validate element. This should prevent msi from doing that check when it > tries to apply to the patch. Heath, any ideas? > > > > <PatchBaseline Id="RTM"> > <Validate ProductId="no" UpgradeCode="no" ProductVersion="Major" > ProductVersionOperator="GreaterOrEqual"/> > </PatchBaseline> > > > > <snip />
Patch.cs.patch
Description: Binary data
------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
