No worries.  Happens all the time.  I didn't notice it either in the code 
review.

Just don't let it happen again.  <wink/>

From: Neil Sleightholm [mailto:[email protected]]
Sent: Saturday, January 24, 2009 07:05
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] NAntTasks doesn't support newer light options

My first patch and I messed up! I have reopened the bug because I missed the 
attributes on the fileversions option (see below) - it was in my version but 
not the patch. Apologies.

/// <summary>
/// Gets or sets the option to add a 'fileVersion' entry to the MsiAssemblyName 
table.
/// </summary>
 [BooleanValidator]
 [TaskAttribute("fileversions")]
public bool FileVersions

Neil

From: Rob Mensching [mailto:[email protected]]
Sent: 23 January 2009 08:07
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] NAntTasks doesn't support newer light options

Cool.  It's in now.

From: Neil Sleightholm [mailto:[email protected]]
Sent: Sunday, January 18, 2009 14:54
To: [email protected]
Subject: [WiX-devs] NAntTasks doesn't support newer light options

I have posted a fix to this here: 
http://sourceforge.net/tracker2/?func=detail&atid=642714&aid=2517287&group_id=105970.

Neil

Neil Sleightholm
X2 Systems Limited
[email protected]<mailto:[email protected]>

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to