I would say yes (new Boolean options should default to false, so use Enable
instead of Suppress if it shouldn't be enabled by default) and yes (which
gives others the chance to review the changes before merging into the
mainline).
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Saturday, October 27, 2012 9:30 AM
To: Windows Installer XML toolset developer mailing list
Subject: [WiX-devs] WixStdBA: Showing ActionData
Looking for some feedback on a change I had proposed and am preparing to
submit. I've tweaked WixStdBA to show MSI package ActionData on the
Progress dialog. I think this feature should need to be explicitly turned on
in order to maintain the existing behavior. As of now, I introduced a
SuppressActionData attribute to the bal:WixStandardBootstrapperApplication
element but it feels strange that all the other Suppress options default to
False/No and this one defaults to True/Yes. I could change this around an
make it an EnableActionData attribute.
What would be the preferred attribute name and behavior? Is the process of
submitting changes still creating a fork on Codeplex, submitting the
changes, and issuing a pull request?
Thanks,
Jacob
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
