Exactly why I was asking, but it has to be a conscious decision to allow adding
of a named control in the BA theme to turn on behavior. On the down side, if
there isn’t a schema modification how would I get this mystery behavior
documented? Would the documentation best fit into “Changing the WiX Standard
Bootstrapper Application Branding”?
As for Text vs Data, Text is only the INSTALLMESSAGE_ACTIONSTART and data is
everything. By everything a good example would be during CopyFiles you’d see
every file but for Text you’d just see that we started to copy files.
In the case of the WixBA, the following code looks like Wix shows “Data”
ProgressViewModel.cs:
private void ExecuteMsiMessage(object sender,
ExecuteMsiMessageEventArgs e)
{
lock (this)
{
this.Message = e.Message;
e.Result = this.root.Canceled ? Result.Cancel : Result.Ok;
}
}
If you wanted it to be “Text” you could make the change as:
private void ExecuteMsiMessage(object sender,
ExecuteMsiMessageEventArgs e)
{
lock (this)
{
If (InstallMessage.ActionStart == e.MessageType)
{
this.Message = e.Message;
}
e.Result = this.root.Canceled ? Result.Cancel : Result.Ok;
}
}
If you are ok with it, I’ll do some cleanup to remove the schema changes and
then update my fork and submit a pull request.
From: Rob Mensching [mailto:[email protected]]
Sent: Monday, February 18, 2013 11:31 AM
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] WixStdBA: New feature development
1. Is this necessary? What if we always set the value into the control and the
owner of the theme can control whether it shows up? That saves us one more
"bit" of data (I'm mostly thinking complexity exposed to user).
2. Cool. This is what makes me wonder if #1 is necessary.
Overall, seems reasonable. One new question:
3. What is difference between "text" and "data". What do those end up showing
in the UI like?
On Mon, Jan 21, 2013 at 6:28 AM, Hoover, Jacob
<[email protected]<mailto:[email protected]>> wrote:
1. I added WixStandardBootstrapperApplication/@EnableActionMessage with a
new custom type having values of none, text, data. BalCompiler had to be
modified to read this data and populate an additional column in the table for
the BA to consume.
2. Logic inside of OnExecuteBegin will set the same options based on the
existence of the two named controls.
From: Neil Sleightholm [mailto:[email protected]<mailto:[email protected]>]
Sent: Saturday, January 19, 2013 5:29 PM
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] WixStdBA: New feature development
3. I posted the changes I made here but no one replied, I had to assume you
weren’t interested.
As a summary this is what I have done:
• Resized HyperlinkLicense and RtfLicense so they are the same size as
the default WiX UI – this is useful if you need to show an MSI internal UI.
• Add welcome message to HyperlinkLicense install page.
• Add support for Radio buttons on the option and install pages.
• Add support for checkboxes on the install page (they are already
supported on the options page).
• Add support for second directory folder on the option page.
• Add Hyperlink2Theme theme (and example) that supports a larger logo
on the install page (see images below).
• Add example textbox on the options page (this is part of the standard
BA but not documented).
• Added install version number to HyperlinkLicense install page.
• Reformat the RtfLicense to have flat licence textbox.
• Add preprocessor instruction to create an auto increment version
(like the C# AssemblyInfo format 1.0.*)
• Support for Bundle self-updates
I have to say I am in two minds about how this should progress. I like the fact
that mine is standalone, you can just download it and use it to enhance it. On
the other hand if it was part of the code more people could use it.
Neil
From: Rob Mensching [mailto:[email protected]]
Sent: 19 January 2013 17:36
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] WixStdBA: New feature development
1. What sort of changes did you make to the schema to support the scenario.
This may be the ideal way to go... but I'm not sure what the changes were.
<smile/>
2. I'm okay if we just need to document the "well-known identifiers" for the
wixstdba UI. Granted there isn't a lot of documentation for wixstdba now, but
that's straight forward enough to fix. This solution sounds reasonable as
well... but I don't know how to contrast it against #1 without more details on
#1. <smile/>
3. The last part is Neil's call. I honestly haven't had cycles to go dig into
the differences but if he thinks it'd be good to bring into WiX proper then a
conversation like you just started here is fantastically appropriate. <smile/>
It's been a busy but good week. I'm all smiley and stuff. <smile/>
On Sat, Jan 19, 2013 at 8:37 AM, Hoover, Jacob
<[email protected]<mailto:[email protected]>> wrote:
In the 3.6 time frame I had dabbled in Wix and modifying the schema to allow
for showing ActionData / ActionText within WixStdBA. I created a fork, but
never did the pull request because it didn’t seem right. In 3.7, I merged my
changes and have since removed the need to modify anything other than WixStdBA.
I made the change so that if there were controls named ExecuteActionDataData or
ExecuteActionDataText it would detect it and then display it there. While this
is far less intrusive, it seems a bit “secret sauce” like, so before I do the
commit and push I’d like some thoughts on which of the two implementations
would be preferred. Also, do you think this feature would ever make it into
WixStdBA, or is this doomed to live in a fork.
In addition, Neil has some interesting modifications in his
ExtBA. Are there any plans to merge his changes back into WixStdBA, or is it
going to stay as a core starting point but not have features added back into it?
Thanks,
Jacob
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET<http://ASP.NET>, C# 2012, HTML5,
CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122912
_______________________________________________
WiX-devs mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET<http://ASP.NET>, C# 2012, HTML5,
CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122412
_______________________________________________
WiX-devs mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
The Go Parallel Website, sponsored by Intel - in partnership with Geeknet,
is your hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials, tech docs,
whitepapers, evaluation guides, and opinion stories. Check out the most
recent posts - join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs
