Agreed. :) That’s why I’m suggesting we remove the second half of the check
(looking for a newer version) because it breaks sticky patching. It’s likely a
patch bundle (even an addon bundle) has a newer Burn version so no burn.*
arguments are passed (except for relationtype), including
burn.ignoredependencies, which is needed to facilitate proper ref-counting
(including the feature completion changes I’m pushing hard to be able to push
publicly).
It’s because burn doesn’t pass any burn.* arguments and eats any it doesn’t
understand I think this is a safe change. We’ve made it internally already and
have found no negative ramifications in any of our scenarios (and you know how
complex some of them get).
Heath Stewart
VS Pro Deployment Experience, Microsoft
<http://blogs.msdn.com/heaths> http://blogs.msdn.com/heaths
From: Rob Mensching [mailto:r...@robmensching.com]
Sent: Tuesday, May 7, 2013 8:49 AM
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] Burn protocol version check breaks sticky patching
A BA should never get a "-burn." based command-line argument. Burn eats all
those and processes the ones it understands. It would be a bug if a BA got them
since they are internal Burn implementation details.
On Tue, Apr 16, 2013 at 4:40 PM, Heath Stewart <hea...@outlook.com
<mailto:hea...@outlook.com> > wrote:
The BA would then get the switch and may not understand or handle it.
Core wire format shouldn't need to change and any messages between bundles
could be versioned like Windows messages if absolutely necessary.
- Heath from Windows Phone
_____
From: Bob Arnson <mailto:b...@joyofsetup.com>
Sent: 4/16/2013 3:23 PM
To: wix-devs@lists.sourceforge.net <mailto:wix-devs@lists.sourceforge.net>
Subject: Re: [WiX-devs] Burn protocol version check breaks sticky patching
Does it even matter if there's a value to the switch as long as any switch that
starts with burn. is ignored?
Alternately, we could (should?) separate the Burn wire protocol from the
private command-line switches, as they have different compatibility bars.
On 12-Apr-13 20:12, Heath Stewart wrote:
Regarding pseudobundle.cpp, there is a version check that makes sure the
related bundle engine version is >= the last breaking change (3.6.2221.0) and
<= the current version. But if you build an addon or patch related bundle with
a newer version of Burn (which is very likely), then a host of burn.* switches
are not passed (oddly, -burn.related.* is, which seems inconsistent). One
example that does not get passed – since it’s only passed for Burn EXEs – is
–burn.ignoredependencies.
If all new burn.* switches require a separate between switch and parameter (if
any parameter at all), do we really need this check? Any burn.* variables that
are not understood are thrown away.
Heath Stewart
VS Pro Deployment Experience, Microsoft
http://blogs.msdn.com/heaths
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net <mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
--
sig://boB
http://joyofsetup.com/
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net <mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
