The bulk of the tests are junk. They were written back in the days when VS
was going to ship the WiX toolset. When that didn't happen they dumped a
bunch of test code on us and said, "Good luck with that!" There's some good
things in there but it'll take a while to sort out the good from the bad.

Much of the infrastructure is overkill. I've just about got the xUnit.net
infrastructure all in place. When that is done, it's a matter of picking
through the existing test code and porting what is good over to the new
infrastructure. For example, all the Burn tests are good.

And no, the build currently does not run the tests. Many of the tests
modify machine state in a big way and we wouldn't want the build machine
touched in that way. In the xUnit conversion, I'm also making it much
easier to get the tests on a separate machine and run there.


On Sun, May 12, 2013 at 9:38 PM, Hoover, Jacob
<[email protected]>wrote:

> As I ported my hg instances changes to git and 3.8, I noticed we seem to
> have dead test data. SimpleInstanceTransform/*
>
> I also noted and fixed a bug in the verifier class which caused a leaked
> msi handle.
>
> I have 2 commits pushed and I intend on documenting the changes and then
> submitting a pull request.
>
> Does the official build not run all tests?
>
> Jacob
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> WiX-devs mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wix-devs
>
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
WiX-devs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to