Taking into account what has been said so far, here are some examples if we
just extend ProductSearch.
Here we just add an "UpgradeCode" attribute:
<!--Enumerates related products and returns the highest version found.-->
<ProductSearch UpgradeCode="{SOME-GUID}" Variable="AcmeProductVersion" />
Rob mentioned returning all installed languages but sounds like Bob is
possibly on the fence for that one(?). However, if that were to be
implemented, adding a "Return" {highestVersion, all} attribute could allow
this authoring:
<!--Enumerates related products and returns a semicolon delimited list of
all languages found.-->
<ProductSearch UpgradeCode="{SOME-GUID}" Result="language" Return="all"
Variable="AcmeProductLanguage" />
If you just wanted the language of the most recent version then omit the
"Return" attribute as the default would be "highestVersion":
<!--Enumerates related products and returns the language of the highest
version found.-->
<ProductSearch UpgradeCode="{SOME-GUID}" Result="language"
Variable="AcmeProductLanguages" />
And of course if you want to get all versions:
<!--Enumerates related products and returns all versions found.-->
<ProductSearch UpgradeCode="{SOME-GUID}" Return="all"
Variable="AcmeProductVersions" />
As Bob mentioned, adding a "ProductCode" attribute would make things
clearer but "Guid" would still be supported and would always infer a
ProductCode.
Thoughts / Opinions?
Is it worth the extra complexity to return all results for related products?
On Wed, Sep 4, 2013 at 4:53 PM, Bob Arnson <b...@joyofsetup.com> wrote:
> Actually, it's +1 on new UpgradeCode and ProductCode attributes to
> ProductSearch rather than adding an attribute that adds a mode to overload
> another attribute. (In WiX v3.x, we'd have to keep the existing attributes
> working as they do today, of course.)
>
> I'd like to approach this with as little functionality as needed. I like
> the idea of returning the highest-versioned product as a version. That
> feeds right into DetectCondition and InstallCondition expressions.
>
> I'm not sure the alternatives I suggested have much value and adding all
> the FindRelatedProducts goop seems like overkill.
>
>
>
> On 04-Sep-13 16:42, Rob Mensching wrote:
>
> 1. Having had many +1's (and many more -1's <smile/>) thrown my way, my
> guess is Bob was voting for a new element.
>
> 2. "Detect all installed language packages". I'm certain if we don't do
> this correctly we'll get bit somewhere.
>
> 3. Agreed. This seems to go along with Bob's suggestion to have a "first,
> all, highest" enum to control the return.
>
> Honestly, these discussions are usually easier if we're discussing real
> examples. Can you throw out some XML examples of what you're thinking that
> might address all the feedback and we can tweak from there?
>
>
>
> On Wed, Sep 4, 2013 at 10:38 AM, Jack Hennessey
> <jhennessey5...@gmail.com>wrote:
>
>> 1. Was your +1 for using a new attribute in the ProductSearch element
>> or for creating a new element altogether?
>>
>> 2. I agree that most of the time you are just looking for the latest
>> version so you can do a comparison. I am having trouble thinking of a use
>> case for returning all related products but I'm sure one exists...does
>> anyone have one?
>>
>> 3. I like how ProductSearch lets you get at other information as well
>> (and can see it being extended in the future to support more of the stuff
>> here:
>> http://msdn.microsoft.com/en-us/library/windows/desktop/aa370130%28v=vs.85%29.aspx).
>> That is why I think it would be nice to keep things in one element if
>> possible.
>>
>>
>>
>> On Fri, Aug 30, 2013 at 11:19 PM, Bob Arnson <b...@joyofsetup.com> wrote:
>>
>>> On 30-Aug-13 18:14, Rob Mensching wrote:
>>> > 1. What about using a separate attribute or maybe a new element? It
>>> > might be good to show a few examples to see which works best.
>>> > Especially since UpgradeCode can actually find multiple products.
>>> +1
>>>
>>> > 2. What if you find several products that have the same version
>>> > number? It'd almost be better to return all ProductCodes that match.
>>> > This is why I suggested a new element may be better, since there may
>>> > end up many ways to slice the results. <sigh/>
>>> > This feature was never terribly straight forward because the result is
>>> > an Array of Guids, not a single Guid, and Burn doesn't support Arrays.
>>> > <smile/>
>>> 80 percent case (90 maybe?) would be covered by a boolean result with a
>>> min-version check. But maybe another Result enum for boolean, first
>>> match, all matches semicolon delimited.
>>>
>>> --
>>> sig://boB
>>> http://joyofsetup.com/
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
>>> Discover the easy way to master current and previous Microsoft
>>> technologies
>>> and advance your career. Get an incredible 1,500+ hours of step-by-step
>>> tutorial videos with LearnDevNow. Subscribe today and save!
>>>
>>> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
>>> _______________________________________________
>>> WiX-devs mailing list
>>> WiX-devs@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/wix-devs
>>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
>> Discover the easy way to master current and previous Microsoft
>> technologies
>> and advance your career. Get an incredible 1,500+ hours of step-by-step
>> tutorial videos with LearnDevNow. Subscribe today and save!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
>> _______________________________________________
>> WiX-devs mailing list
>> WiX-devs@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/wix-devs
>>
>>
>
>
> ------------------------------------------------------------------------------
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> WiX-devs mailing
> listWiX-devs@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wix-devs
>
>
> --
> sig://boBhttp://joyofsetup.com/
>
>
>
> ------------------------------------------------------------------------------
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
> _______________________________________________
> WiX-devs mailing list
> WiX-devs@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wix-devs
>
>
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
