I'm fine with just fixing this one bug. I just wanted to be "professional" and
report my additional findings / concern and let you decide.
----------------------------------------
From: "Rob Mensching" <r...@robmensching.com>
Sent: Friday, October 25, 2013 6:24 PM
To: "WiX toolset developer mailing list" <wix-devs@lists.sourceforge.net>
Subject: Re: [WiX-devs] Issue 3786 - Localization: Installer ES/ IT: Duplicate
hotkey 'A' in the EULA page.
We should not "morph" bugs from one issue into another. If bug needs to
morph, it's best to open a new bug that clearly describes the new issue (and
maybe references the old bug). The old bug can then be resolved with a
reference the new bug so the opener knows why their bug wasn't fixed. In this
case, it sounds like you have a fix for the specific issue (yay!) so it can be
resolved (when the pull request is accepted). If you'd like to do a full
scan to see if there are additional issues that would be fantastic. Please do
open bugs on specific issues as you find them. From: Christopher Painter
[mailto:chr...@iswix.com]
Sent: Thursday, October 24, 2013 12:29 PM
To: WiX toolset developer mailing list; WiX toolset developer mailing list
Subject: Re: [WiX-devs] Issue 3786 - Localization: Installer ES/ IT: Duplicate
hotkey 'A' in the EULA page.
They are mutually exclusive with each other. However the conflict is with
either of them and the global Back button which is &Atras.
But the real question is how deep should we search to resolve the bug. Just
the one asked or keep looking for more?
----------------------------------------
From: "Hoover, Jacob" <jacob.hoo...@greenheck.com>
Sent: Thursday, October 24, 2013 1:55 PM
To: "WiX toolset developer mailing list" <wix-devs@lists.sourceforge.net>
Subject: Re: [WiX-devs] Issue 3786 - Localization: Installer ES/ IT: Duplicate
hotkey 'A' in the EULA page.
The Update vs UpdateNoShield should be mutually exclusive though, right?
From: Christopher Painter [mailto:chr...@iswix.com]
Sent: Thursday, October 24, 2013 1:39 PM
To: wix-devs@lists.sourceforge.net
Subject: [WiX-devs] Issue 3786 - Localization: Installer ES/ IT: Duplicate
hotkey 'A' in the EULA page.
I've been investigating this defect and I've noticed that the description is
old. The conflict is actually with the back button now not the next button.
But I also noticed something else. The es-ES wxl defines:
Back &Atras
Next &Siguiente
If I search through the wxl/built MSI I find 2 other conflicts:
--------------------------
VerifyReadyDlg
--------------------------
Update &Actualizar
UpdateNoShield &Actualizar Do we need to do a more systemic review / wxl unit
tests for reserved hotkeys or is it ok to just fix these and wait for defects
on any others that might be out there?
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
