Wow, I'm really surprised that works. However, if it does, awesome.
The rule is pretty simple with only a couple qualifications
1. When WiX toolset users take a minor release of the WiX toolset they
must recompile all of their WiX related code (.wxs, extensions, custom actions,
etc). That recompile should compile without any new issues.
2. Except:
a. A WiX Toolset user cannot patch MSIs with different versions of the
WiX toolset (even build number changes). It might work sometimes but it
definitely won't work all the time. Patching is just too sensitive to changes
for us to make this always work.
b. We will make breaking changes for security or really bad bugs whenever
necessary. We will apologize profusely but bad stuff cannot be allowed to live.
So, if changes can be made to the Burn engine and balutil/mba such that
wixstdba and WixBA do not require code changes then all of the above is
satisfied.
Is that clearer?
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Wednesday, February 5, 2014 12:55 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
I was able to modify the C++ interface definition to include a default value
STDMETHOD(Detect)(
__in_opt HWND hwndParent = 0
) = 0;
And the code compiles both with and without the default argument provided in
C++. I didn't modify the C# definition of the interface, as I provided an
overloaded implementation that works both ways. As of now, it's a bit of a
grey area to me as to what parts are set in stone and can't be changed in a
point release.
From: Bob Arnson [mailto:b...@joyofsetup.com]
Sent: Sunday, February 02, 2014 5:33 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
Are default arguments forbidden in COM interfaces as used in Burn? (Answer:
Well, doing so doesn't break the build...Whether they violate an unchecked rule
is something my bing-fu cannot answer.) A default-argument crutch in v3.x
(removed in v4.0) would be tolerable.
I'd also be OK with implementing this as a new method on IBootstrapperEngine as
long as we immediately deprecate it so it can be clean again in v4.0.
On 23-Jan-14 19:39, Rob Mensching wrote:
It's C++ code. An COM interface in this case (to interact well with managed
code as well as native code). How would you do a function overload in this case?
From: Sean [mailto:rhal...@hotmail.com]
Sent: Thursday, January 23, 2014 4:25 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
I guess 4.0 then. It doesn't make sense to me to add a new function that will
do the exact same thing.
Is there any plans for dropping C support so you can do modern things like
overload a function? :) (or I guess it's <smile/> in this group?)
Maybe add a SetDetectWindow(HWnd) for 3.x?
________________________________
From: r...@robmensching.com<mailto:r...@robmensching.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Thu, 23 Jan 2014 16:59:47 +0000
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
I should have been explicit, all current users of Burn will be broken when they
upgrade from WiX v3.8 (or less) to WiX v3.9. We don't do that in dot releases.
I think the change is fine, but to do so would require taking it in WiX v4
(where breaking changes are expected).
From: Sean [mailto:rhal...@hotmail.com]
Sent: Thursday, January 23, 2014 8:57 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Self update bundles, the detect issue.
Since Apply already requires an HWnd, I actually don't think it's a big deal to
change Detect to require one, too.
Sean
________________________________
From: r...@robmensching.com<mailto:r...@robmensching.com>
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Date: Thu, 23 Jan 2014 16:41:21 +0000
Subject: [WiX-devs] Self update bundles, the detect issue.
>From this pull request:
>https://wix.codeplex.com/SourceControl/network/forks/jchoover/Wix/contribution/5911
> I'm looking for more input on the issue surround the
>IBootstrapperEngine::Detect() signature changing. I see a couple ways around
>this:
1. Move the pull request to WiX v4.0 where we can "break" (in this case:
enhance) the Detect API as we see fit.
2. Add another method to the IBootstrapperEngine called
"DetectWIthUpdates()" or something (Jacob already proposed something like
"Detect2()" which is not high on my list of good names <smile/>).
Personally, I'm leaning towards option #1. Option #2 isn't completely horrible
but there are already ways to skip update detection (if it is slow, for
example) and adding a top level method seems overkill.
Comments? Suggestions?
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More
Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development
Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More
Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development
Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________ WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
--
sig://boB
http://joyofsetup.com/
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
