It would be cool to turn analysis on in the ship build. We should get in
the habit of building both debug and ship. The build's so fast now,
there's little reason not to.
On 06-Feb-14 17:29, Rob Mensching wrote:
Totally open to suggestions here. I'm all for build breaks for these
type of things if possible.
*From:*Blair Murri [mailto:os...@live.com]
*Sent:* Wednesday, February 5, 2014 9:23 PM
*To:* wix-devs@lists.sourceforge.net
*Subject:* Re: [WiX-devs] C/C++ Code Analysis warnings
How hard would it be to add analysis to the current build tree (in a
way that doesn't break the build when the tools aren't available)?
Blair
*From:*Bruce Cran <mailto:br...@cran.org.uk>
*Sent:* ?Monday?, ?February? ?03?, ?2014 ?8?:?27? ?AM
*To:* wix-devs@lists.sourceforge.net
<mailto:wix-devs@lists.sourceforge.net>
It looks like we should find a way to run the C/C++ code analysis more
often: switching the Platform Toolset to v120 (the _xp toolsets don't
support static analysis) and running it generates quite a few (453 in
engine) warnings. It includes things that appear to be plain bugs, like:
C6302 *Invalid character string argument to format function*
Format string mismatch: character string passed as _Param_(3) when a
wide character string is required in call to 'LogErrorString' Actual
type: 'char *'.
*engine* - cabextract.cpp (Line 557)
C6230 *Invalid HRESULT use as boolean*
Implicit cast between semantically different integer types: using
HRESULT in a Boolean context.
*engine* - cache.cpp (Line 1686)
and problems with annotations, such as:
C6001 *Using uninitialized memory*
Using uninitialized memory '*psczWorkingPath'.
* Line 221: '*psczWorkingPath' is not initialized
* Line 227: Enter this branch, (assume 'vfInitializedCache')
* Line 234: Enter this branch, (assume 'vfRunningFromCache')
* Line 236: '*psczWorkingPath' is an Input to
'PathForCurrentProcess' (declared at
c:\users\bcran\workspace\wix39\src\libs\dutil\inc\pathutil.h:99)
* Line 236: '*psczWorkingPath' is used, but may not have been
initialized
*engine* - cache.cpp (Line 236)
--
Bruce
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
--
sig://boB
http://joyofsetup.com/
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
