Done,
https://wix.codeplex.com/SourceControl/network/forks/jchoover/Wix/contribution/6218
Any chance we could have a chat today (before the online meeting) about adding
a HWND parameter to detect with a default value to determine if it really is a
breaking change?
From: Rob Mensching [mailto:r...@robmensching.com]
Sent: Tuesday, February 11, 2014 4:18 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Feat #4193: SHA-1:
b646e096742b1fdb608d34bb3fddf3ee76006ef5
Send a fix, reference the original bug.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Tuesday, February 11, 2014 1:25 PM
To: WiX toolset developer mailing list
Subject: [WiX-devs] Feat #4193: SHA-1: b646e096742b1fdb608d34bb3fddf3ee76006ef5
Bob,
Your commit (SHA-1: b646e096742b1fdb608d34bb3fddf3ee76006ef5) where you did
style cleanup has introduced a bug.
So far I've found:
HRESULT DAPI BundleEnumRelatedBundle(
__in LPCWSTR wzUpgradeCode,<---------------------------------------------
__in BUNDLE_INSTALL_CONTEXT context,
__inout PDWORD pdwStartIndex,
__out_ecount(MAX_GUID_CHARS+1) LPWSTR lpBundleIdBuf
)
{
HRESULT hr = S_OK;
...
LPWSTR wzUpgradeCode = rgsczBundleUpgradeCodes[i];
<---------------------------------------------
if (wzUpgradeCode && *wzUpgradeCode)
{
if (CSTR_EQUAL == ::CompareStringW(LOCALE_INVARIANT,
NORM_IGNORECASE, wzUpgradeCode, -1, wzUpgradeCode, -1))
Do I need to log a bug on this or just submit a fix?
Thanks,
Jacob
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
