As discussed in today's meeting, I've taken all feedback from my last pull
request and implemented it.
The one question I did have is an expected behavior around what to do if the
update detection fails for any reason. I see this as a decision that should be
made by the BA (which is where I think the nRecommendation was originally
heading). The easiest way of doing this would be for the BA to manage the
state. If it fails the first time, the BA could call Detect a second time and
inside of the OnDetectUpdateBegin callback return IDNOACTION instead of IDOK.
While this should work, it is a bit overkill. If the engine could call back to
the UX to allow the BA to decide to pass or fail (via OnDetectUpdateComplete
and modifying the VOID return to be an int) the BA could decide if it cares
that an update detection failed or not.
For this initial pull request, is it acceptable to expect the BA to call
detect twice? (In 4.x, we could modify the signature of OnDetectUpdateComplete
to eliminate the need for this.)
Thanks,
Jacob
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
