Yeah, and:
1. Sending a large change as your first submission to the WiX toolset (aka: before building up a reputation with us so we develop trust in your submissions) means it's going to require a more thorough review. 2. Then adding a comment saying that only a portion of the code review is really important but leaving it intermingled with all the other code means more work for us to sort out what there is really interesting. 3. Then adding dependencies on large subsystems of Windows and/or Visual Studio that we don't use anywhere in the codebase (like ATL) means that we have to think about the implications of that and whether it's worth it to take a dependency for the change. So, I took a quick look at the pull request as I do with all pull requests. You've got quite a doozy there. I probably should have commented on it saying so... and honestly, I need to write a blog post about the three points above (and others). On top of that I have a very interesting character flaw that you might not now about. That character flow is also affecting your pull request. I very much dislike being pinged. Using a tone that could be perceived as "demanding" (whether intended or not) that I do some work for you on my volunteer time is a good way to push your requests to the bottom of my volunteer stack. It's not a good behavior of mine. I try to keep in check but sometimes, when I have lots of other things pulling at my attention, I indulge it. Again, this is something I should blog so people are aware and not be completely surprised when regularly pinging me seems to cause other pull requests to be reviewed before theirs. I will tell you that, if you desire, you can very easily counteract my character flaw by asking what you can do to help. My desire to help people learn seriously outweighs my pettiness about being pinged. Anyway, I'm sorry. We really should get to the pull request. I just haven't had the activation energy to slog through it. Sorry. From: Wesley Manning [mailto:wmann...@dynagen.ca] Sent: Tuesday, March 25, 2014 10:39 AM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] Interested in Contributing [P] You still have to wait till Rob (or Bob?) does a review of your code. They may request changes. Maybe they'll even reject it. :) From: Steve-Ogilvie [mailto:steven.ogil...@titus.com] Sent: March-25-14 2:34 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] Interested in Contributing [P] Classification: Public It was signed Feb 26th "Steven Ogilvie, All parties have completed the envelope 'Outercurve Foundation Assignment Agreement - WiX'. To view, download or print the completed document click below." [Image removed by sender. Latest TITUS News!]<http://www.titus.com/TMCPolicy_footer_link_landingpage.php> This message has been marked as Public by Steven Ogilvie on March-25-14 1:33:15 PM. The above classification labels were added to the message by TITUS Message Classification. For more information visit www.titus.com<http://www.titus.com/>. From: Hoover, Jacob [via Windows Installer XML (WiX) toolset] [mailto:ml-node+[hidden email]</user/SendEmail.jtp?type=node&node=7593748&i=0>] Sent: March-25-14 1:02 PM To: Steven Ogilvie Subject: Re: Interested in Contributing I'm not Rob, but the agreement is with Outercurve, not GitHub or CodePlex. Once it's signed, you should be golden (unless they need to modify the agreement again). -----Original Message----- From: Steve-Ogilvie [mailto:[hidden email]</user/SendEmail.jtp?type=node&node=7593744&i=0>] Sent: Tuesday, March 25, 2014 11:23 AM To: [hidden email]</user/SendEmail.jtp?type=node&node=7593744&i=1> Subject: Re: [WiX-devs] Interested in Contributing What about the assignment agreements we did for CodePlex in February? are they non void for GitHub? I am still waiting for Code review on my pull request on GitHub for 3.x steve -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/Interested-in-Contributing-tp7593421p7593742.html Sent from the wix-devs mailing list archive at Nabble.com. ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ WiX-devs mailing list [hidden email]</user/SendEmail.jtp?type=node&node=7593744&i=2> https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ WiX-devs mailing list [hidden email]</user/SendEmail.jtp?type=node&node=7593744&i=3> https://lists.sourceforge.net/lists/listinfo/wix-devs ________________________________ If you reply to this email, your message will be added to the discussion below: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/Interested-in-Contributing-tp7593421p7593744.html To unsubscribe from Interested in Contributing, click here. NAML<http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> ________________________________ View this message in context: RE: Interested in Contributing [P]<http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/RE-Interested-in-Contributing-P-tp7593748.html> Sent from the wix-devs mailing list archive<http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/wix-devs-f687561.html> at Nabble.com.
<<inline: image001.jpg>>
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
