1. I worry very little about CodeDom. Plus if it's additive then a recompile should work cleanly. If a tri-state for Cache attribute is what we'd use in WiX v4.0 then I think we can add it in WiX v3.x okay.
2. What if we just do this in WiX v4.0 instead? At some point taking changes in WiX v3.x that are "more interesting" needs to stop right? At some point the new functionality needs to be in WiX v4.0. Honestly, interesting feature work needs to start in WiX v4.0 if we're still shipping WiX v4.0 this year (as think we should). Note: I haven't looked at the proposed change at all so this *may* not apply right now... but we need to start thinking that way soon, right? _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ -----Original Message----- From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Sunday, April 27, 2014 9:51 PM To: Bob Arnson; wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] Compatibility and style discussion Links: 1. https://github.com/wixtoolset/wix3/pull/21/files#r12034827 2. https://github.com/wixtoolset/wix3/pull/15/files#r12034610 On 28-Apr-14 00:49, Bob Arnson wrote: > Not the kind of style discussion that devolves, I hope. > > 1. Sean sent a pull request that added an option to force packages to > be cached by specifying an AlwaysCache attribute (yes/no) on the > package. Caching is already controlled by a Cache attribute (yes/no). > Sean gets bonus internet points for throwing a message if you were to > specify both attributes. But the need to do that indicates a schema > smell: Having two attributes to control three states is a bit wonky. > One option is to create a new enum type to specify the three states. > (This is done elsewhere in WiX, yielding perhaps my favorite boolean > type: YesNoButton.) The downside is that while authoring would be > compatible, there's a slight non-zero chance that someone could have a > CodeDOM or similar dependency on the original type. > > Should we stick with the two attributes in v3.x and clean it up in v4.0? > > 2. Heath sent a pull request that, among other things, adds two > methods to IBootstrapperApplication. Last time, we decided on a > "no-error recompile required" policy. Heath suggested versioned > interfaces. I'd be OK with that, as long as we don't carry them over > to v4.0. > > Objections/concerns? > > > -- > sig://boB > http://joyofsetup.com/ ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available. Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
