I took the change as is. Then I fixed the package restore to use xunit v1.9.2
and move the Test target out of the test traversal project into a proper
.testproj.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Heath Stewart [mailto:hea...@outlook.com]
Sent: Thursday, June 12, 2014 9:39 AM
To: Windows Installer XML toolset developer mailing list
Subject: Re: [WiX-devs] Test overhaul
So it's okay for me to rebase my bug fixes on it? Many include tests, and
others I want to make sure don't reqress anything that might be different on
the “outside”.
I.e. you're taking the commit as-is (no commit id change)?
- Heath from his Surface Pro
From: Rob Mensching<mailto:r...@firegiant.com>
Sent: Thursday, June 12, 2014 9:36 AM
To: Windows Installer XML toolset developer mailing
list<mailto:wix-devs@lists.sourceforge.net>
Heath,
The pull request looks really good. The infrastructure improvements you made
seemed very much in line with the changes I made to initially get Xunit to
support our basic integration test needs.
This is an awesome step and we can keep improving from here.
The root issue was that Xunit is a unit test framework, not an integration test
framework. We’re stretching it a bit to make it handle the integration tests
for Burn. However, all the additions we’ve added have seemed reasonable. So I’m
still pretty encouraged by the benefits of being able to use Xunit as our unit
test and integration test framework.
Anyway, thanks for the huge update of the test framework. Will get this in very
soon.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
