On a related note, I sent a PR for the breaking bug regarding these functions.
The key change was that even when fZeroMemory is TRUE you still have to retain
the original string in pwzOriginal. Also did a bit more clean up while I was at
it.
- Heath from his Surface Pro
From: Heath Stewart
Sent: Thursday, June 19, 2014 9:03 AM
To: Windows Installer XML toolset developer mailing list
Understood, but you could create a helper function private to strutil and have
both secure and non-secure variants call that.
- Heath from his Surface Pro
From: Bob Arnson
Sent: Thursday, June 19, 2014 9:00 AM
To: Windows Installer XML toolset developer mailing list
On 6/19/2014 11:13 AM, Heath Stewart wrote:
I meant that we should use *Secure in lieu of *Allocate*. StrAllocFormatted and
StrAllocateFormatted, for example, are confusing if you don't know the code.
What's the difference, one might ask? But StrAllocFormatted and
StrAllocFormattedSecure are pretty obvious.
Currently the old functions are wrappers around the new with a FALSE for
fZeroOnRealloc. This is good in reducing duplication. I agree *Alloc* and
*Allocate* are confusing without reading the code, though mostly to those
who've internalized the old names. :) Suffixes might make that a bit clearer.
--
sig://boB
http://joyofsetup.com/
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
