That is only part of the fix, we also need to flag the pseudo bundle cacheType
as BURN_CACHE_TYPE_YES. In my local testing, inside of
EngineForApplication.cpp, in SetUpdate I added:
// Prevent this package from being cleaned if we actually Plan an
UpdateReplace.
m_pEngineState->update.package.cacheType = BURN_CACHE_TYPE_YES;
After PseudoBundleInitialize.
Without this change, you will see bundle A's cleanup trying to remove bundle B.
If bundle B is a fast update and bundle A is slow to tear down, you would end
up with a bundle installed but removed from the cache.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Tuesday, July 15, 2014 2:21 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Wix 3.9: Bundle Self Updates
What did you think of Sean's change? https://github.com/wixtoolset/wix3/pull/110
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Tuesday, July 15, 2014 10:32 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] Wix 3.9: Bundle Self Updates
Ref: http://wixtoolset.org/issues/4472/
Rob/Bob,
I've dug into this more, and I think the proper fix is to revert my change in
PlanCleanPackage and modify the PsuedoBundle package to have a cacheType of
yes. This should prevent the planned cleanup when the older bundle exits, and
should eliminate the fallout I think I caused where the updated bundle isn't
cleaning up the out of date packages. My only question is should I make this
the default behavior of PseudoBundleInitialize, or should SetUpdate modify the
package after it's been initialized.
Thanks,
Jacob
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
