Usually it's old code. Back then we were still learning how to be consistent
with .NET Framework v1.1 "BCL". We certainly we're aware how to be consistent
in a world of generics.
FireGiant and I have been slowly improving the "data classes" for the WiX
toolset in v4 now that we can do breaking changes. Tend to fix the "data
classes" when fixing some large part of the compiler, linker or binder.
So, yes, for the first time in a long time (aka: in v4) we can make the WiX
toolset more BCL like.
_______________________________________________________________
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Heath Stewart [mailto:hea...@outlook.com]
Sent: Saturday, September 27, 2014 9:48 AM
To: wix-devs@lists.sourceforge.net
Subject: [WiX-devs] Following recommended patterns in wix4
While making some changes in WiX 4 I noticed a lot of counter-patterns, like
Field.IsIdentical. One or two more classes have that as well, and it makes me
wonder why you wouldn't override Equals as is the pattern recommended in .NET.
Implementing IComparable<T> is another way that opens a bit more possibilities
depending on usage, which is why I implemented it on various OM classes higher
than Field.
Is there some specific reason for not following guidance? Any reason someone
couldn't fix this and make the class libraries more consistent with the .NET
BCL and many other libraries built atop it?
Heath Stewart
Software Design Engineer
Visual Studio, Microsoft
http://blogs.msdn.com/heaths
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
