Rob/Bob,
  Do you have any status information so to where the 4.x tools sit?  I was 
trying to rework the unit tests to get the burn related ones functional, and I 
kept running into issues.

Ex:
  The 4.x binder requires bind variables to be paths, not files.  This breaks 
all tests which pass in the MSI/MSP file names as bind variables.  I can fix 
this with adding Path.GetDirectoryName around the existing calls to the 
BundleBuilder.Output, or I could add a read only property to BundleBuilder that 
does the same.

  The WixToolset.Tool.PyroCommandLine doesn't initialize the default values of 
properties, which cause access violations.

I also ran into a legitimate bug inside of WixToolset.Data.Pdb, the Read method 
does a comparison that is incorrect

            if (!reader.LocalName.Equals("wixPdb" == reader.LocalName))
            {
                throw new XmlException();
            }

>From there, I was haing issue with Pyro not able to create a patch because the 
>Files table was null.  When the 4.x refactoring was done, did you do ay manual 
>testing to verify basic functionality?  Do you have any docs on the 
>significant refactoring done, or any hints on where to start with the patch 
>generation process failing? (What tool/section of code is responsible for 
>populating the file table which is consumed by pyro?)

P.S. For any of the test to work they rely on bits from my outstanding pull 
request, as the BindBundleCommand was no longer populating 
packageLanguage/packageManufacturer.

Thanks,
Jacob

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs

Reply via email to