Thanks, It now starts the custom action. But I have another problem: In the custom action "Start" which activates a vbs there is a line in the vbs file which changes the property of "DONEXT" to "1", but its value doesn't change, and the "Finish" Custom action doesn't run. Do you maybe what's the reason the property doesn't change?
In the properties I have: <Property Id="INSTALLERROR">0</Property> <Property Id="DONEXT">0</Property> In the Custom Actions I have: <Custom Action="Start" After="InstallFinalize"> (INSTALLERROR = 0) AND Not(Installed)</Custom> <Custom Action="Finish" After="Start"> (DONEXT = 1) AND Not(Installed)</Custom> In the vbs file I have: Session.Property("DONEXT")="1" -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Brian Simoneau Sent: Thursday, August 21, 2008 17:34 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Custom action Condition on Property value? If that Property element is copied exactly, then there is the problem. You are setting INSTALLERROR to Value="0". Change it to <Property Id="INSTALLERROR">0</Property> Or <Property Id="INSTALLERROR" Value="0"/> To set INSTALLERROR to 0. -Brian Simoneau -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Yuval David Sent: Thursday, August 21, 2008 8:06 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Custom action Condition on Property value? I changed it to: <Property Id="INSTALLERROR"> Value="0" </Property> <Custom Action="Start" After="InstallFinalize"> (INSTALLERROR = 0) AND Not(Installed)</Custom> But it still doesn't activate the custom action. It seems as he doesn't pass the condition (INSTALLERROR = 0). Even thaw I initialized the property to "0" as you can see. Is there a problem with the property initialization? -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Michael Faden Sent: Thursday, August 21, 2008 11:25 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Custom action Condition on Property value? Hi Yuval, is a question of operator priority: It should look like that <Custom Action="Start" After="InstallFinalize"> (INSTALLERROR = 0) AND Not(Installed)</Custom> Your term means INSTALLERROR=(0 AND NOT Installed) and this is of course always false Mike Yuval David wrote: > Hello, > > I'm trying to run a custom action with a condition that verify that a > property value of INSTALLERROR is 0, but it doesn't work > > The syntax is probably not right. Can some one tell me what is the > problem please? > > > > > > <Property Id="INSTALLERROR"> Value="0" </Property> > > > > <Custom Action="Start" After="InstallFinalize"> > > INSTALLERROR = 0 AND Not Installed</Custom> > > > > > > ------------------------------------------------------------------------ - > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > ------------------------------------------------------------------------ - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------ - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------ - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users