Are you compiling with UNICODE defined? If so I believe you have a buffer overrun here:
ofn.nMaxFile = sizeof(szOriginalPath); You should use countof() instead of sizeof(). Otherwise, I'm not really sure what the issue is. Showing the part of the log file that has the error might be helpful. -----Original Message----- From: jballe [mailto:j...@visionpeople.dk] Sent: Sunday, February 08, 2009 01:56 To: wix-users@lists.sourceforge.net Subject: [WiX-users] CustomAction following specific CustomAction fails I have a project using several customactions schduled during the UI as immediate. It actually works for almost everything but I have one issue left. In the UI the user can select to install a license file. I have a C++ customaction which opens the OpenFile dialog and sets it to a property. Later in the UI is invoked some managed CustomActions for IIS or MSMQ stuff depending on the user's selections. If the C++ customaction is run the next customaction (no matter which one) fails with the error code 2896 (Executing action xxx failed). If the C++ custom action is not run, it works as it is supposed to. I have to made this custom action as C++ as it didn't worked with a managed custom action - and that probably makes sense that DTF can't open a dialog for the msi handle, I guess. While logging the installation I do not get any notices around the actions and the C++ OpenFile dialog action closes the MSIHANDLES correctly. Below is text from Logfile regarding the OpenFile dialog Action 10:15:34: BrowseFileDialog. Action start 10:15:34: BrowseFileDialog. MSI (c) (CC:0C) [10:15:34:475]: Creating MSIHANDLE (28) of type 790542 for thread 5388 MSI (c) (CC:E8) [10:15:34:475]: Invoking remote custom action. DLL: C:\[snip...]\Temp\MSI516D.tmp, Entrypoint: BrowseForFile MSI (c) (CC!88) [10:15:34:498]: Creating MSIHANDLE (29) of type 790541 for thread 4488 MSI (c) (CC!88) [10:15:36:934]: PROPERTY CHANGE: Adding PATHTOFILE property. Its value is [snip...]. MSI (c) (CC!88) [10:15:36:934]: Closing MSIHANDLE (29) of type 790541 for thread 4488 MSI (c) (CC:E8) [10:15:36:938]: Closing MSIHANDLE (28) of type 790542 for thread 5388 Action ended 10:15:36: BrowseFileDialog. Return value 1. I guess the problem is around this BrowseFileDialog CustomAction as the result is the some for my next two different customactons and they work without this BrowseFileDialog. I attach the sourcecode of my C++ custom action: http://n2.nabble.com/file/n2292259/CustomAction.cpp CustomAction.cpp Thanks you all! Best regards, Jesper -- View this message in context: http://n2.nabble.com/CustomAction-following-specific-CustomAction-fails-tp2292259p2292259.html Sent from the wix-users mailing list archive at Nabble.com. ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users