Bob, What are the consequences of an excessively long command line? A truncated command line could be dealt with, but if the result is "undefined behaviour" and a destabilised msi, that's another matter.
Thanks Dominic -----Original Message----- From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: 18 March 2009 18:30 To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Is it safe to use a CustomAction longer than 255 bytes? Dominic Herity wrote: > First question: Is it safe to exceed 255 bytes in a command line? > Unknown. Generally yes, but you're going outside the scope of what's documented to work and there are cases where it's known to not work. > Assuming it is safe, I need to run it in a build environment that treats > warnings as errors. I can disable the warning with -sice:ICE03, but that > seems to leave me vulnerable to other buffer overflow conditions. > And it's always possible that the command line would exceed 8191 bytes and > I'd want to catch that? > Second question: What's the safest way to eliminate this warning? > Validation can be disabled only entirely or at the individual ICE level. There's no way to tell ICE03 to report everything but a certain class of errors. And there's no way to tell it to check for an additional class of errors (>8191). So, don't pass ultra-long command lines. Better yet, don't use EXE custom actions at all: http://blogs.msdn.com/heaths/archive/2007/10/24/exe-custom-actions-are-bad.aspx http://blogs.msdn.com/windows_installer_team/archive/2007/10/20/integration-hurdles-for-exe-custom-actions.aspx -- sig://boB http://joyofsetup.com/ ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users About Microsoft Ireland: www.microsoft.com/ireland Microsoft Ireland Operations Limited. A company incorporated and registered in Ireland number 256796. Microsoft Ireland Research. A company incorporated and registered in Ireland number 342235. Registered office 70 Sir John Rogerson's Quay, Dublin 2, Ireland ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
