If you explicitly set REINSTALL then all other feature properties like ADDLOCAL are ignored (because REINSTALL takes precedence; see http://msdn.microsoft.com/en-us/library/aa371175.aspx).
The default REINSTALLMODE is also "omus", so unless it is explicitly set or defined in the Property table (this should generally not be done) it will be "omus". Any non-versioned files updated - where the modification timestamp is > the creation timestamp - will not be overwritten by default. This is by design. Unless all files are overwritten when REINSTALLMODE contains "a" - and this applies to ALL files in a product, it is not granular at the file, component, or feature level - it is not updated because it's considered a user edit. If you're installing files that you expect a user to edit, either 1) don't install them; just create them on first launch, or 2) service their content using a custom action (for example, XmlConfig in WiX is good for changes to XML files that users might edit). See http://blogs.msdn.com/heaths/archive/2006/12/21/installation-guidelines-for-user-editable-configuration.aspxfor some ideas of how to service user-editable files. Of course, if you're installing a user-editable file in a per-machine app either you're installing to a user-editable directory - and per-machine applications should not write per-user data during installation; or you're requiring elevated privileges to write your file with on Vista+ may not be a good customer experience. Just something to consider when designing your app composition. As for why the maintenance dialog is coming up when installing a patch - that's because really all patch operations are is a reinstall of your product with a transform or transforms applied (or removed if uninstalling a patch). See http://blogs.msdn.com/heaths/archive/2005/09/12/464047.aspx for more details. On Tue, Sep 23, 2008 at 5:20 AM, Ilya Slobodin <islobo...@yandex.ru> wrote: > Hi, > > REINSTALL=ALL REINSTALLMODE=omus are set from the UI when Repair > button is pressed. Haven't you changed the test.txt before the patch > is applied? > > My experiments show that patches are installed better without setting > REINSTALL and REINSTALLMODE. If these properties are set, this can > cause problems with component action state dependencies, e.g. MoveFile > records. See my post "Patch install: MoveFiles and component action > states" earlier in this list. There is also a sample that patches the > text file. > > The problem is that when REINSTALL=ALL REINSTALLMODE=omus are set, > action state of all components becomes "Local" but no action is really > executed on the components not included in the patch. > > When REINSTALL=ALL REINSTALLMODE=omus are not set, action states of > the files being patched are set to "Local" by the msi engine. > > Best regards, > Ilya Slobodin > > ----- Original Message ----- > From: "Robert O'Brien" <robert.obr...@microsoft.com> > To: "'General discussion for Windows Installer XML toolset.'" > <wix-users@lists.sourceforge.net> > Sent: Tuesday, September 23, 2008 7:23 AM > Subject: Re: [WiX-users] Patch creation problems > > > > You need to launch the msp using the command line and the properties > > REINSTALL=ALL REINSTALLMODE=omus. If you want to be able to use > > your msp by double clicking on it you need to add something like the > > following to your wix sources so that those property values will get > > assigned automatically before processing begins. > > > > <!-- for msp small update or minor upgrade processing --> > > <CustomAction Id="SetMspSmallUpdateOrMinorUpgradeReInstallProperty" > > Property="REINSTALL" Value="ALL" /> > > <CustomAction > > Id="SetMspSmallUpdateOrMinorUpgradeReInstallModeProperty" > > Property="REINSTALLMODE" Value="omus" /> > > > > <InstallExecuteSequence> > > <Custom Action="SetMspSmallUpdateOrMinorUpgradeReInstallProperty" > > After="LaunchConditions">PATCH And Installed</Custom> > > <Custom > > Action="SetMspSmallUpdateOrMinorUpgradeReInstallModeProperty" > > After="LaunchConditions">PATCH And Installed</Custom> > > <!-- or <Custom > > Action="SetMspSmallUpdateOrMinorUpgradeReInstallProperty" > > After="LaunchConditions">QFEUpgrade=2</Custom> > > <Custom > > Action="SetMspSmallUpdateOrMinorUpgradeReInstallModeProperty" > > After="LaunchConditions">QFEUpgrade=2</Custom>--> > > > > -----Original Message----- > > From: Scott Sam [mailto:s...@clearviewecm.com] > > Sent: Monday, September 22, 2008 9:00 AM > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] Patch creation problems > > > > > > When I double click on my msp file I get the welcome dialog, > > followed > > by the maintenance dialog, giving me the choice to change, repair or > > remove. Choosing repair or change, will cause the patch to show up > > in > > add/remove programs, but the text file does not show the changes > > that I > > made. > > > > Problem 1: Why do I get the maintenance dialog? I would like to > > just > > double click the msp file and then have the patch be applied. Is > > there > > any way to do this? > > Problem 2: the changes aren't being applied. How do I fix this? > > > > I'm using wix version 3.0.4429.0 > > > > To create my patch I'm using the following method: > > 1. Compile original msi > > 2. Change a text file that is included in the msi. > > 3. Compile new msi > > 4. Create a transform between the two msi's. > > torch.exe -p -xi original\Product.wixpdb Product.wixpdb -out > > Patch\Diff.Wixmst > > 5. Build the patch > > pyro.exe Patch\Patch.WixMsp -out Patch\Patch.msp -t RTM > > Patch\Diff.wixmst > > > > here is my patch.wxs file: > > <?xml version="1.0" encoding="utf-8"?> > > <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";> > > <Patch AllowRemoval="yes" Manufacturer="Clearview Software" > > DisplayName="Test Patch" Description="Small Update Patch" > > Classification="Update" MinorUpdateTargetRTM="yes"> > > <Media Id="5000" Cabinet="RTM.cab"> > > <PatchBaseline Id="RTM" /> > > </Media> > > > > <PatchFamilyRef Id="TestPatchFamily" /> > > </Patch> > > <Fragment> > > <PatchFamily Id="TestPatchFamily" Version="5.0.907.0" > > Supersede="yes"> > > <ComponentRef Id="test.txt"/> > > </PatchFamily> > > </Fragment> > > > > </Wix> > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge > > Build the coolest Linux based applications with Moblin SDK & win > > great prizes > > Grand prize is a trip for two to an Open Source event anywhere in > > the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge > > Build the coolest Linux based applications with Moblin SDK & win > > great prizes > > Grand prize is a trip for two to an Open Source event anywhere in > > the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win great > prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > -- Heath Stewart Deployment Technologies Team, Microsoft http://blogs.msdn.com/heaths ------------------------------------------------------------------------------ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
