To move the EXE from the File table to the binary table, you do the following:
Remove your <File Source='path\to\tao_imr.exe' .../> tag (along with the component it is in) and put in (under the Product or Fragment tag) a tag like this: <Binary Id='tao_imr.exe' Source='path\to\tao_imr.exe'/> Then in your CustomAction tags replace the FileKey attribute with a BinaryKey attribute (with the same value). -----Original Message----- From: Jiang, Chunyan (GE Healthcare) [mailto:chunyan.ji...@ge.com] Sent: Tuesday, August 11, 2009 2:37 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] WG: Custom Action during Upgrade got error The problem has been resolved. I set the path as: file://[APPLICATIONFOLDER]/VPCommon/Locator.ior Everything works fine. So the rootcause is no the custom action sequence setting, but the exe wrong setting. Cheers! -----Ursprüngliche Nachricht----- Von: Jiang, Chunyan (GE Healthcare) Gesendet: Dienstag, 11. August 2009 10:51 An: General discussion for Windows Installer XML toolset. Betreff: Re: [WiX-users] WG: Custom Action during Upgrade got error Hi Blair, As you said, to determine why the exe returns error is the key. I dug into this problem and found that even I set the CA as: <CustomAction Id='UpgradeStopServices1' FileKey='tao_imr.exe' ExeCommand=' -ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER' Return='asyncNoWait' /> tao_imr.exe will start in the directory where I installed the software, say d:\vp6wix\vpcommon. However, tao_imr.exe will search for file::/Locator.ior. And it goes to CURRENT PATH, which is set as c:\windows\system32. But Locator.ior is not there. That's why tao_imr.exe doesn't work. I think I should set the path of Locator.ior same as installation path, say d:\vp6wix\vpcommon. Is it correct if I set it as: file::/APPLICATIONFOLDER/vpcommon/Locator.ior ? I have defined the installation directory as: <Directory Id="TARGETDIR" Name="SourceDir"> <Directory Id="APPLICATIONFOLDER" Name="VP6Wix"> Regards, Chunyan -----Ursprüngliche Nachricht----- Von: Jiang, Chunyan (GE Healthcare) Gesendet: Dienstag, 11. August 2009 09:40 An: General discussion for Windows Installer XML toolset. Betreff: Re: [WiX-users] WG: Custom Action during Upgrade got error Thanks Blair! I tried the methods as you suggested. Here I call the CA as: <Custom Action="UpgradeStopServices1" After="InstallFinalize">PREVIOUSFOUND</Custom> 1. echo %ERRORLEBEL% shows only '0'. 2. When I set the return attribute to the following three value, in the log file, it shows: 'asyncNoWait' | UpgradeStopServices1. Return value 0. 'ignore' | UpgradeStopServices1. Return value 1. 'check' | Error 1722. There is a problem with this Windows Installer package. A program run as part of the setup did not finish as expected. Contact your support personnel or package vendor. But all the three attributes setting don't run the exe succeeded. 3. I removed the exe name in the ExeCommand 4. I use tao_imr.exe in several custom actions. I don't know how to put it in the binary table. Maybe I should try it. Could you please tell me how to do it? Best regards, Chunyan -----Ursprüngliche Nachricht----- Von: Blair [mailto:os...@live.com] Gesendet: Montag, 10. August 2009 20:41 An: 'General discussion for Windows Installer XML toolset.' Betreff: Re: [WiX-users] WG: Custom Action during Upgrade got error If after you run your command-line to test the function you then run the command D:\VP6Wix\VPCommon> echo %ERRORLEVEL% And you see anything except for 0 you will see why Windows Installer thinks your command failed. You should probably determine why that exe is returning an error and resolve that. If you can't and the error is legitimate, then you would then need to change your Return attribute to either 'ignore' or 'asyncNoWait' which will have the effect of ignoring any/all errors that could occur wrt that custom action (meaning you will never be informed of failures involving that action, no matter what failure it was). Also, regarding the ExeCommand attribute, IIRC you don't need to repeat the exe name, just the command tail. So, you would have this: <CustomAction Id='UpgradeStopServices1' FileKey='tao_imr.exe' ExeCommand='-ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER' Return='check' /> Or this: <CustomAction Id='UpgradeStopServices1' FileKey='tao_imr.exe' ExeCommand='-ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER' Return='ignore' /> Does your product use the tao_imr.exe file outside of this custom action? If not, rather than install it you may consider putting it in the binary table so you don't have any internal restriction on the sequencing of the action. -----Original Message----- From: Jiang, Chunyan (GE Healthcare) [mailto:chunyan.ji...@ge.com] Sent: Monday, August 10, 2009 5:51 AM To: General discussion for Windows Installer XML toolset. Subject: [WiX-users] WG: Custom Action during Upgrade got error I changed the Custom Action call as: <Custom Action="UpgradeStopServices1" After="InstallFinalize">PREVIOUSFOUND</Custom> But there is still the error in log as last email. The Custom Action is defined as: <CustomAction Id='UpgradeStopServices1' FileKey='tao_imr.exe' ExeCommand='tao_imr -ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER' Return='check' /> If I run the function in the command line, there is message: D:\VP6Wix\VPCommon>tao_imr -ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER ACE (5544|3760) LN::open_dll - Failed to open TAO_Codeset: Error: check log for details. ACE (5544|3760) Unable to create service object for TAO_Codeset Successfully shut down server <VPWEBSERVER> Although there is error, but the function works. Is it the reason that Custom Action doesn't work? Regards, Chunyan -----Ursprüngliche Nachricht----- Von: Jiang, Chunyan (GE Healthcare) Gesendet: Montag, 10. August 2009 13:45 An: General discussion for Windows Installer XML toolset. Betreff: [WiX-users] Custom Action during Upgrade got error Hi Wix-users, I have one Custom Action, which should be called during upgrade. I called it as: <Custom Action="UpgradeStopServices1" After="CostFinalize">PREVIOUSFOUND</Custom> But there is error in installation log, when I upgrade the msi: MSI (s) (F8:78) [12:59:27:612]: Doing action: UpgradeStopServices1 Action 12:59:27: UpgradeStopServices1. Action start 12:59:27: UpgradeStopServices1. MSI (s) (F8:78) [12:59:27:956]: Note: 1: 1722 2: UpgradeStopServices1 3: d:\VP6Wix\VPCommon\tao_imr.exe 4: tao_imr -ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER MSI (s) (F8:78) [12:59:27:956]: Note: 1: 2205 2: 3: Error MSI (s) (F8:78) [12:59:27:956]: Note: 1: 2228 2: 3: Error 4: SELECT `Message` FROM `Error` WHERE `Error` = 1722 Error 1722. There is a problem with this Windows Installer package. A program run as part of the setup did not finish as expected. Contact your support personnel or package vendor. Action UpgradeStopServices1, location: d:\VP6Wix\VPCommon\tao_imr.exe, command: tao_imr -ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER MSI (s) (F8:78) [12:59:33:362]: Note: 1: 2205 2: 3: Error MSI (s) (F8:78) [12:59:33:362]: Note: 1: 2228 2: 3: Error 4: SELECT `Message` FROM `Error` WHERE `Error` = 1709 MSI (s) (F8:78) [12:59:33:362]: Product: VP6 Wix -- Error 1722. There is a problem with this Windows Installer package. A program run as part of the setup did not finish as expected. Contact your support personnel or package vendor. Action UpgradeStopServices1, location: d:\VP6Wix\VPCommon\tao_imr.exe, command: tao_imr -ORBInitRef ImplRepoService=file::/Locator.ior shutdown VPWEBSERVER Is there something wrong with After="CostFinalize"? Regards, Chunyan ---------------------------------------------------------------------------- -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ---------------------------------------------------------------------------- -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ---------------------------------------------------------------------------- -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ---------------------------------------------------------------------------- -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ---------------------------------------------------------------------------- -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ---------------------------------------------------------------------------- -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
